feat: [IOCOM-1133,IOCOM-1235,IOCOM-1372] Push Notification Opt In screen, new DS #5734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagopa-github-bot
changed the title
Affected stories
|
|
🎉 All dependencies have been resolved ! |
# Conflicts: # ts/features/pushNotifications/components/__tests__/NotificationPreviewSample.test.tsx # ts/features/pushNotifications/hooks/usePreviewMoreInfo.tsx # ts/features/pushNotifications/sagas/checkNotificationsPermissionsSaga.ts # ts/features/pushNotifications/sagas/checkNotificationsPreferencesSaga.ts # ts/features/pushNotifications/screens/OnboardingNotificationsInfoScreenConsent.tsx # ts/features/pushNotifications/screens/OnboardingNotificationsPreferencesScreen.tsx # ts/features/pushNotifications/screens/__tests__/OnboardingNotificationsInfoScreenConsent.test.tsx # ts/features/pushNotifications/screens/__tests__/OnboardingNotificationsPreferencesScreen.test.tsx # ts/features/pushNotifications/utils/configurePushNotification.ts # ts/sagas/startup/__tests__/checkNotificationsPermissionsSaga.test.tsx # ts/screens/profile/NotificationsPreferencesScreen.tsx
forrest57
approved these changes
May 23, 2024
Vangaorth
added a commit
that referenced
this pull request
May 24, 2024
…rty (#5749)⚠️ This PR depends on #5734⚠️ ## Short description This PR adds the `NOTIFICATION_PERMISSION: "enabled"/"disabled"` property to both super and profile properties. It also refactors the `checkNotificationsPreferencesSaga` to be more readable. ## List of changes proposed in this pull request - `ts/screens/profile/analytics/index.ts`: type and utility to convert from boolean to type - `ts/mixpanelConfig/profileProperties.ts` and `ts/mixpanelConfig/superProperties.ts`: property added with related code to compute its value - `ts/features/pushNotifications/sagas/checkNotificationsPreferencesSaga.ts`: code flow refactored to be more readable (with full tests) - `ts/features/pushNotifications/screen/OnboardingNotificationsInfoScreenConsent.ts`: modal dismissal moved to the saga above ## How to test Using the io-dev-api-server, check that: - the analytics event value is read properly before and after the permission is given - the original flow for the profile notification onboarding still works - for an onboarded user, the permission popup is shown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR aligns the Push Notifications Opt In screen and the profile push notification settings to the new DS
upper part
scrolled down
Reminder On
Reminder Off
Both on
Bottom sheet
On Off
Off On
Off Off
List of changes proposed in this pull request
How to test
Using the io-dev-api-server, configure the profile in order to have both
reminder_statusandpush_notifications_content_typeset to undefined. Perform a login and the opt-in screen should appear. Check that both values are properly set after tapping the "Continue" button.For the profile screen, navigate to it and change switches' values