Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross): [IOAPPX-296] Remove native-base from dependencies #5558

Merged
merged 317 commits into from May 14, 2024

Conversation

CrisTofani
Copy link
Contributor

@CrisTofani CrisTofani commented Feb 29, 2024

Caution

This PR depends on #5506

Short description

This PR removes native-base and its related packages from dependencies.

List of changes proposed in this pull request

  • Remove native-base and relative theme
  • Remove Header and StyleProvider components
  • Remove Content and Form components
  • Replace legacy Toast (from native-base) with the new IOToast from io-app-design-system
  • Replace legacy FooterWithButtons (based on native-base buttons) with the new FooterWithButtons from io-app-design-system
  • Temporarily replace legacy ListItemComponent with Pressable native component, waiting for the complete overhaul with the new io-app-design-system components
  • Replace NB's TextInput with the native one
  • Remove react-native-iphone-x-helper and react-native-keyboard-aware-scroll-view unused dependencies

Warning

Known issue
Screens that use the BaseScreenComponent could be rendered with a huge amount of space on top when used in combination with SafeAreaView

For other issues, please refer to the discussion below

Credits

This PR is the result of:

  • Some early group sessions with the entire IO Mobile Dev team
  • Individual contributions by @CrisTofani and @dmnplb

How to test

Launch the app in the local environment and accurately test the most used flows by the citizens, especially:

  • Onboarding and authentication flow
  • Payment flow
  • ID Pay entire flow
  • Message detail with different use cases (SEND, remote content, legacy Covid cerification, etc…)

@CrisTofani CrisTofani changed the base branch from IOPLT-342-react-native-upgrade to master February 29, 2024 16:17
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Feb 29, 2024

Affected stories

  • ⚙️ IOAPPX-296: Rimozione native-base da io-app

Generated by 🚫 dangerJS against cb2bc47

Copy link
Contributor

@LazyAfternoons LazyAfternoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested different flows with a focus on FCI, including accessibility.

EDIT : I added a ticket on our cross board if that makes sense to you.

@LazyAfternoons LazyAfternoons changed the title chore: Remove native-base from dependencies [IOAPPX-296] Remove native-base from dependencies May 13, 2024
@pagopa-github-bot pagopa-github-bot changed the title [IOAPPX-296] Remove native-base from dependencies chore(Cross): [IOAPPX-296] Remove native-base from dependencies May 13, 2024
@CrisTofani
Copy link
Contributor Author

We should check the Payments and Messages related flows to be safe. If nothing is broken, we should merge. What do you think?

It seems that the testID on TextInputValidation and TextInputPassword is not well propagated... what do you think?

@shadowsheep1 Addressed in the last 2 commits now it should be fine

Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Tested on the current payment flow and the to-be payment section and it works without any problem

@dmnplb dmnplb merged commit 027e1c4 into master May 14, 2024
13 checks passed
@dmnplb dmnplb deleted the chore-remove-native-base branch May 14, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cross 💀 Dead matter Graphic assets or chunks of code that are no longer referenced or needed NativeBase dismissal 🥷🏼 Better if no one notices
Development

Successfully merging this pull request may close these issues.

None yet

8 participants