New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Cross): [IOAPPX-296] Remove native-base
from dependencies
#5558
Conversation
…e-remove-native-base
Affected stories
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested different flows with a focus on FCI, including accessibility.
EDIT : I added a ticket on our cross board if that makes sense to you.
native-base
from dependenciesnative-base
from dependencies
native-base
from dependenciesnative-base
from dependencies
@shadowsheep1 Addressed in the last 2 commits now it should be fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Tested on the current payment flow and the to-be payment section and it works without any problem
Caution
This PR depends on #5506
Short description
This PR removes
native-base
and its related packages from dependencies.List of changes proposed in this pull request
native-base
and relative themeHeader
andStyleProvider
componentsContent
andForm
componentsToast
(fromnative-base
) with the newIOToast
fromio-app-design-system
FooterWithButtons
(based onnative-base
buttons) with the newFooterWithButtons
fromio-app-design-system
ListItemComponent
withPressable
native component, waiting for the complete overhaul with the newio-app-design-system
componentsTextInput
with the native onereact-native-iphone-x-helper
andreact-native-keyboard-aware-scroll-view
unused dependenciesWarning
Known issue
Screens that use the
BaseScreenComponent
could be rendered with a huge amount of space on top when used in combination withSafeAreaView
For other issues, please refer to the discussion below
Credits
This PR is the result of:
How to test
Launch the app in the local environment and accurately test the most used flows by the citizens, especially: