Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalization Slovenian (Slovenščina) #4131

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

damjang
Copy link

@damjang damjang commented Oct 12, 2022

This is my first try of adding slovenian localization to io-app:

  • I only translate all needed files in locales/sl, but not try or do a check of them. This should be done before merge.

  • I also add the new language in /blob/master/ts/i18n.ts (I hope it is ok, maybe need to be added also in export const localeToLocalizedMessageKey?).

  • I also change a little the italian index.yml to uniform it (adding everywhere quotation marks, remove not needed white lines/new lines) and correct some little errors I find when translating from italian to slovenian. Maybe this can be useful when porting translations/localization to some new/better translation system as mentioned somewhere :-)

BR

@damjang damjang requested review from a team and thisisjp as code owners October 12, 2022 13:26
@github-actions
Copy link

This pull request is stale because it has been open for 60 days with no activity. If the pull request is still valid, please update it within 14 days to keep it open or merge it, otherwise it will be closed automatically.

@github-actions github-actions bot added the stale label Dec 15, 2022
@AliceAzzolini
Copy link
Contributor

Hi @damjang, thanks a lot for your kind help and for contributing to the project! We will review your PR and get back to you in case we have any questions.

Thanks again – and happy holidays!

@github-actions github-actions bot removed the stale label Dec 29, 2022
@dmnplb dmnplb added the i18n Activities related to internationalization label Feb 3, 2023
There still is a dependency from a remote generated enum that needs to be updated by a different team before the application can compile
@Vangaorth
Copy link
Contributor

Hi @damjang, I updated the code to properly compile. Unfortunately, there is still a dependency from a remote generated enum that needs to be enhanced by another team before the code in this PR can work successfully

@dmnplb
Copy link
Contributor

dmnplb commented Apr 6, 2023

This PR should fix this issue.

@github-actions
Copy link

This pull request is stale because it has been open for 60 days with no activity. If the pull request is still valid, please update it within 14 days to keep it open or merge it, otherwise it will be closed automatically.

@github-actions github-actions bot added the stale label Jun 15, 2023
@thisisjp
Copy link
Contributor

still working on backend side to support additional languages, stay tuned 🤞

@github-actions github-actions bot removed the stale label Jun 22, 2023
@github-actions
Copy link

This pull request is stale because it has been open for 60 days with no activity. If the pull request is still valid, please update it within 14 days to keep it open or merge it, otherwise it will be closed automatically.

@github-actions github-actions bot added the stale label Aug 22, 2023
@dmnplb dmnplb removed the stale label Aug 22, 2023
@github-actions
Copy link

This pull request is stale because it has been open for 60 days with no activity. If the pull request is still valid, please update it within 14 days to keep it open or merge it, otherwise it will be closed automatically.

@github-actions github-actions bot added the stale label Oct 22, 2023
@thisisjp thisisjp removed the stale label Oct 23, 2023
Copy link

This pull request is stale because it has been open for 60 days with no activity. If the pull request is still valid, please update it within 14 days to keep it open or merge it, otherwise it will be closed automatically.

@github-actions github-actions bot added the stale label Dec 29, 2023
@damjang
Copy link
Author

damjang commented Dec 29, 2023

Any news on this? Hm, more than a year have passed ...

@github-actions github-actions bot removed the stale label Jan 1, 2024
@damjang
Copy link
Author

damjang commented Feb 27, 2024

Bump

Copy link

This pull request is stale because it has been open for 60 days with no activity. If the pull request is still valid, please update it within 14 days to keep it open or merge it, otherwise it will be closed automatically.

@github-actions github-actions bot added the stale label Apr 29, 2024
@dmnplb dmnplb removed the stale label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend-block i18n Activities related to internationalization
Development

Successfully merging this pull request may close these issues.

None yet

5 participants