Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep Hugging Face PURL version component case as-is #213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maitre-matt
Copy link
Contributor

Update test data so version component is not lower-cased

@williamboman
Copy link
Contributor

williamboman commented Jan 5, 2023

I believe this will cause implementations that respect the following rule in the PURL-TYPES spec to fail:

The version is the model revision Git commit hash. It is case insensitive and must be lowercased in the package URL.

edit: Or hm I might've spoke too soon, the above probably only applies to the canonical_url? The version component itself is parsed as-is?

@maitre-matt
Copy link
Contributor Author

I am not sure: I am not clear whether the version JSON field is about the canonical URL or the original URL. The test could go either way.

@williamboman
Copy link
Contributor

FWIW this breaks the test case in an implementation I wrote. I'm not implying that my implementation is correct (it's merely my interpretation of this particular part of the spec). Thought I'd share!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants