Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GetLogs parsing to log object #9985

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

acohen4
Copy link
Contributor

@acohen4 acohen4 commented Apr 24, 2024

No description provided.

@acohen4 acohen4 requested a review from jrockway April 24, 2024 21:27
msg.NativeTimestamp = timestamppb.New(t)
}
}
if val := msg.Object.Fields["log"].GetStringValue(); val != "" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the "log" field? I think you're hitting the case where Loki is misconfigured and responses are wrapped inside this: https://docs.docker.com/config/containers/logging/json-file/

We need to handle this higher up, when we first get the line back from Loki. It also means you're using a weird dev environment if you're running into this.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 58.19%. Comparing base (9569e42) to head (d1f7006).
Report is 3 commits behind head on master.

Files Patch % Lines
src/server/logs/logs.go 41.66% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9985      +/-   ##
==========================================
- Coverage   58.21%   58.19%   -0.03%     
==========================================
  Files         614      614              
  Lines       75461    75465       +4     
==========================================
- Hits        43931    43915      -16     
- Misses      30978    30997      +19     
- Partials      552      553       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants