[CORE-2238] Loki in testpachd fast-follow #9913
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8-loki-in-testpachd
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## jonathan/core-2238-loki-in-testpachd #9913 +/- ##
========================================================================
- Coverage 58.05% 58.05% -0.01%
========================================================================
Files 609 609
Lines 74034 74034
========================================================================
- Hits 42982 42978 -4
- Misses 30499 30508 +9
+ Partials 553 548 -5 ☔ View full report in Codecov by Sentry. |
robert-uhl
commented
Apr 3, 2024
src/testing/testpachd/main.go
Outdated
| ctx = pctx.Background("cleanup") | ||
| if err := clean.Cleanup(ctx); err != nil { | ||
| ctx := pctx.Background("cleanup") | ||
| if err = clean.Cleanup(ctx); err != nil { |
There was a problem hiding this comment.
I think an error when cleaning up is probably worth not deleting the batch logs? That way it can be debugged.
A sister of setupPachctlConfig.
robert-uhl
commented
Apr 3, 2024
src/testing/testpachd/main.go
Outdated
| // errors cause this, as does SIGINT. | ||
| <-ctx.Done() | ||
| if err := <-errCh; err != nil { | ||
| // wait for pachd to complete |
There was a problem hiding this comment.
There’s no need to wait for context cancellation, since the run goroutine will close errCh when it completes.
robert-uhl
changed the title
…8-loki-in-testpachd
jrockway
force-pushed
the
jonathan/core-2238-loki-in-testpachd
branch
from
37b4b6f
to
f02a218
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.