Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed version range for OSGi import of guava #2886

Merged
merged 1 commit into from May 13, 2024
Merged

Conversation

d0mmi
Copy link
Contributor

@d0mmi d0mmi commented May 8, 2024

Removed version range for OSGi import of guava.
This allows it to be compatible with newer versions.
We had some issues with the default version range that was provided.

This allows it to be compatible with newer versions.
@d0mmi
Copy link
Contributor Author

d0mmi commented May 8, 2024

Would be great if this could also get a release as soon as possible, because this issue currently blocking us 😊

@leleuj
Copy link
Member

leleuj commented May 13, 2024

Does the same problem happen for the master branch?

@d0mmi
Copy link
Contributor Author

d0mmi commented May 13, 2024

Does the same problem happen for the master branch?

i just checked it and yes same thing in master

@leleuj
Copy link
Member

leleuj commented May 13, 2024

Can you submit another PR for the master? Thx

@d0mmi
Copy link
Contributor Author

d0mmi commented May 13, 2024

Can you submit another PR for the master? Thx

done

@leleuj leleuj merged commit 155c933 into pac4j:5.7.x May 13, 2024
4 checks passed
@leleuj
Copy link
Member

leleuj commented May 13, 2024

Thanks for your contribution. Ping me next week for the 5.7.5 release.

@d0mmi
Copy link
Contributor Author

d0mmi commented May 21, 2024

Thanks for your contribution. Ping me next week for the 5.7.5 release.

@leleuj ^^

@leleuj
Copy link
Member

leleuj commented May 21, 2024

Copy that. I will do that this Thursday.

@leleuj
Copy link
Member

leleuj commented May 23, 2024

The release is in progress. It will show up in the Maven central repo soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants