Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add createTokenValidator method in OidcOpMetadataResolver in order to reduce copy-pasted code #2885

Merged
merged 2 commits into from May 13, 2024
Merged

Add createTokenValidator method in OidcOpMetadataResolver in order to reduce copy-pasted code #2885

merged 2 commits into from May 13, 2024

Conversation

ddqof
Copy link
Contributor

@ddqof ddqof commented May 7, 2024

I suggest to add new protected method that allows to override TokenValidator creation logic in OidcOpMetadataResolver subclasses like AzureAdOpMetadataResolver

@leleuj
Copy link
Member

leleuj commented May 13, 2024

Sure. It's cleaner.

@leleuj leleuj merged commit be321de into pac4j:master May 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ddqof @leleuj