Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some defensive-coding checks #251

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add some defensive-coding checks #251

wants to merge 3 commits into from

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Oct 7, 2019

These changes deal with a variety of traceback exposures under certain circumstances that, in practice, occur fairly often:

  • Empty strings / None values on the inputs file path list
  • Not properly respecting formatted_time during the last_keyframe adjustment
  • Blank/short lines in the ffprobe CSV output that don't match the regexp used to parse them

@ferdnyc
videoservice: last_keyframe respect formatted_time
7046db9
@ferdnyc
videoservice: Fix issues with inputs list items
9d9703b 
The list `inputs` can apparently contain empty strings, which means:
- os.remove() will throw TypeError, not FileNotFoundError
- Other os.* functions will be flummoxed if passed NoneType arguments
@ferdnyc
videoservice: Protect ffprobe output parsing
39840d7
@ferdnyc
Copy link
Contributor Author

ferdnyc commented Oct 7, 2019

Whoops, I see that @scrool's #183 also covered a bunch of these, and probably better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ferdnyc