Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redis binaries #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jameshilliard
Copy link

@jameshilliard jameshilliard commented Jul 1, 2020

It seems we also need to update our dependencies for this to work correctly.

Note that for the OSX/Linux binaries I've taken care to ensure that they are highly portable unlike those in #15 by statically linking all libraries other than libSystem on OSX which is not really possible to statically link but should always be included. Windows is untested at this point and version 5.0.9 seems to be the latest native Windows binary available.

$ file src/main/resources/redis-server-6.0.5
src/main/resources/redis-server-6.0.5: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, stripped
$ file src/main/resources/redis-server-6.0.5-32 
src/main/resources/redis-server-6.0.5-32: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), statically linked, stripped
$ otool -L src/main/resources/redis-server-6.0.5.app
src/main/resources/redis-server-6.0.5.app:
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1281.0.0)

@codecov-commenter
Copy link

Codecov Report

Merging #16 into master will increase coverage by 0.46%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #16      +/-   ##
============================================
+ Coverage     72.81%   73.28%   +0.46%     
  Complexity      116      116              
============================================
  Files            20       20              
  Lines           515      509       -6     
  Branches         38       38              
============================================
- Hits            375      373       -2     
+ Misses          118      114       -4     
  Partials         22       22              
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/redis/embedded/RedisExecProvider.java 100.00% <100.00%> (ø) 9.00 <1.00> (ø)
...ain/java/redis/embedded/AbstractRedisInstance.java 86.56% <0.00%> (-0.39%) 14.00% <0.00%> (ø%)
src/main/java/redis/embedded/util/OSDetector.java 20.83% <0.00%> (+1.60%) 3.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 659f4ba...3f1a275. Read the comment docs.

@mrniko
Copy link

mrniko commented Oct 1, 2020

Please also add 5.0.9 binaries for windows from https://github.com/tporadowski/redis/releases

@jameshilliard
Copy link
Author

@mrniko Should be there already, note I have not tested the Windows version as I do not have a suitable dev environment set up at the moment for Windows.

@mrniko
Copy link

mrniko commented Oct 1, 2020

@jameshilliard

I did. It works fine

@AlexeyNezhdanovGardena
Copy link

Hi guys. Is there anything else to be done with this PR? I could help with testing, though only on linux system...

@0kommanix
Copy link

0kommanix commented Jun 30, 2021

Hi guys, would appreciate if you could update Mac OSX binaries to redis >= 6.0.10 as this version includes a fix for a bug that crashes redis on Mac ARM (M1) platforms.

Details can be found here:
redis/redis#8062

@radarsh
Copy link

radarsh commented Jul 19, 2021

Thank you so much for this PR. Although not released, I was able to use your binaries and override Redis for my tests that rely on features of recent Redis versions.

@kenshinji
Copy link

kenshinji commented Jan 26, 2022

Hi guys, would appreciate if you could update Mac OSX binaries to redis >= 6.0.10 as this version includes a fix for a bug that crashes redis on Mac ARM (M1) platforms.

Details can be found here: redis/redis#8062

Any update regarding upgrading redis version to >= 6.0.10? Thanks.

@ripper2hl
Copy link

I don't know but appears this repository is dead, if we do create a redis-embedded organization and add all people with an PR opened in this repository? @kenshinji

@nikeee
Copy link

nikeee commented Apr 22, 2022

Any chance to get this merged and released? @ozimov

@nathanfranke
Copy link

https://github.com/signalapp/embedded-redis is a more up-to-date fork (Maven). It uses Redis 6.2.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
10 participants