#2050 Added Marker Line Style for Line Series #2051
Conversation
There was a problem hiding this comment.
Thank you for this contribution! There are quite a few issues here, but in principle I think the idea is good. Main issues (only marked up a single instance of each with a specific comment):
- Need to use
this.notation when accessing members dashArrayisn't used in most of the render contexts- Some changes to the csprojs that I think shouldn't be there
- This should have its own example rather than modifying the existing on for
MarkerType(makes it easier for people to find the example and feature, and keeps the example code for the given feature simpler)
I've not run this yet to check the behaviour etc. but will do so when I have more time: obviously it will only work with WPF at the moment.
If you don't have time to fix these issues (which presumably have never affected you) then let us know and I'll try to do all the boring bits that are left over.
| @@ -338,7 +338,7 @@ public void DrawRectangle(OxyRect rectangle, OxyColor fill, OxyColor stroke, dou | |||
| } | |||
|
|
|||
| /// <inheritdoc/> | |||
| public void DrawRectangles(IList<OxyRect> rectangles, OxyColor fill, OxyColor stroke, double thickness, EdgeRenderingMode edgeRenderingMode) | |||
| public void DrawRectangles(IList<OxyRect> rectangles, OxyColor fill, OxyColor stroke, double thickness, EdgeRenderingMode edgeRenderingMode, double[] dashArray = null) | |||
There was a problem hiding this comment.
Unused parameter (issue throughout file)
There was a problem hiding this comment.
@VisualMelon What would your expectation to solve this be here to solve this?
Add a new specific method on IRenderContext and use it appropriately in calling classes?
As I noted initially, I hacked into these changes for my personal project years ago, and not familiar with the architecture or the design philosophy, so any direction is greatly appreciated.
|
All valid comments; I will make some amendments and push tonight. |
|
Looks like |
matsydoodles
force-pushed
the
feature/2050-ability-to-set-marker-line-style-on-line-series
branch
from
92488e2
to
013b5af
Compare
| @@ -269,6 +269,7 @@ public static void DrawMultilineText(this IRenderContext rc, ScreenPoint point, | |||
| /// <param name="stroke">The stroke color.</param> | |||
| /// <param name="strokeThickness">The stroke thickness.</param> | |||
| /// <param name="edgeRenderingMode">The edge rendering mode.</param> | |||
| /// <param name="dashArray"></param> | |||
| @@ -32,7 +32,8 @@ public interface IRenderContext | |||
| /// <param name="stroke">The stroke color. If set to <c>OxyColors.Undefined</c>, the extents will not be stroked.</param> | |||
| /// <param name="thickness">The thickness (in device independent units, 1/96 inch).</param> | |||
| /// <param name="edgeRenderingMode">The edge rendering mode.</param> | |||
| void DrawEllipse(OxyRect extents, OxyColor fill, OxyColor stroke, double thickness, EdgeRenderingMode edgeRenderingMode); | |||
| /// <param name="dashArray"></param> | |||
| @@ -42,10 +43,11 @@ public interface IRenderContext | |||
| /// <param name="stroke">The stroke color. If set to <c>OxyColors.Undefined</c>, the ellipses will not be stroked.</param> | |||
| /// <param name="thickness">The stroke thickness (in device independent units, 1/96 inch).</param> | |||
| /// <param name="edgeRenderingMode">The edge rendering mode.</param> | |||
| /// <param name="dashArray"></param> | |||
| @@ -133,7 +135,8 @@ public interface IRenderContext | |||
| /// <param name="stroke">The stroke color. If set to <c>OxyColors.Undefined</c>, the rectangle will not be stroked.</param> | |||
| /// <param name="thickness">The stroke thickness (in device independent units, 1/96 inch).</param> | |||
| /// <param name="edgeRenderingMode">The edge rendering mode.</param> | |||
| void DrawRectangle(OxyRect rectangle, OxyColor fill, OxyColor stroke, double thickness, EdgeRenderingMode edgeRenderingMode); | |||
| /// <param name="dashArray"></param> | |||
| @@ -143,10 +146,11 @@ public interface IRenderContext | |||
| /// <param name="stroke">The stroke color. If set to <c>OxyColors.Undefined</c>, the extents will not be stroked.</param> | |||
| /// <param name="thickness">The stroke thickness (in device independent units, 1/96 inch).</param> | |||
| /// <param name="edgeRenderingMode">The edge rendering mode.</param> | |||
| /// <param name="dashArray"></param> | |||
Add the ability to set the Marker Line Style for Line Series charts.
Been sitting on my hard drive for the last couple of years and figured I should push it up.