Off-by-one wallet decoy selection bug fix (stable branch) #1643
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corrects an off-by-one error in decoy selection that would never select immediately-spendable outputs, and so immediately spending an output would reveal the true output in question. From Monero, PR 8794. The infinite loop quoted here is *also* something that I encountered, though only in regression testing (which uses a fake, sparse chain).
ghost
mentioned this pull request
tewinget
approved these changes
May 24, 2023
darcys22
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects an off-by-one error in decoy selection that would never select immediately-spendable outputs, and so immediately spending an output would reveal the true output in question.
From Monero, PR 8794.
The infinite loop quoted here is also something that I encountered, though only in regression testing (which uses a fake, sparse chain).