Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transformer): Add babel-plugin-transform-dotall-regex #2774

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bschoenmaeckers
Copy link

No description provided.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Mar 20, 2024
@Dunqing
Copy link
Member

Dunqing commented Mar 21, 2024

I think we should oxc-regex-parser to implement this plugin, but the parser still working in progress

Copy link

codspeed-hq bot commented Mar 21, 2024

CodSpeed Performance Report

Merging #2774 will improve performances by 3.32%

Comparing bschoenmaeckers:dotall-regex (3276aca) with main (3c9e77d)

Summary

⚡ 1 improvements
✅ 33 untouched benchmarks

Benchmarks breakdown

Benchmark main bschoenmaeckers:dotall-regex Change
parser_napi[pdf.mjs] 76.5 ms 74.1 ms +3.32%

@Boshen
Copy link
Member

Boshen commented Mar 21, 2024

Leave this to me.

@Boshen Boshen self-requested a review March 21, 2024 03:18
@Boshen Boshen marked this pull request as draft March 21, 2024 03:18
@bschoenmaeckers
Copy link
Author

Leave this to me.

Do you mean you want to implement this plugin yourself (including the other regex plugins)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants