Fix yaml warning #1165
Open
Fix yaml warning #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebasing.
viyatb
requested changes
Aug 21, 2021
owtf/managers/config.py
Outdated
| @@ -32,7 +32,7 @@ def load_config_file(file_path, fallback_file_path): | |||
| # check if the config file exists | |||
| abort_framework("Config file not found at: {}".format(file_path)) | |||
| try: | |||
| config_map = yaml.load(FileOperations.open(file_path, "r")) | |||
| config_map = yaml.load(FileOperations.open(file_path, "r"), Loader=yaml.FullLoader) | |||
There was a problem hiding this comment.
this is actually very insecure - can you use safe_load function provided by the PyYAML? it would be great if you can also fix this anywhere we load YAML files 🙀
There was a problem hiding this comment.
Sure will do that.
|
@EXTREMOPHILARUM can you actually go over the entire codebase and change it to |
|
Sure will go through it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yaml library deprecated the yaml.load function without the Loader parameter. This led to the framework showing a yaml.load warning on every start when configuration YAML files are being loaded.
Description
This PR fixes the warning popup.
Before
After
Reviewers
@viyatb
Types of changes
Checklist: