Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inventory phase 2 #873

Merged
merged 3 commits into from May 13, 2024
Merged

Inventory phase 2 #873

merged 3 commits into from May 13, 2024

Conversation

spitfire305
Copy link
Collaborator

No description provided.

@spitfire305 spitfire305 requested a review from ilestis May 10, 2024 20:41
ilestis
ilestis requested changes May 12, 2024
View reviewed changes
Copy link
Member

@ilestis ilestis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work well with emojis and & signs in the position field?

resources/js/tags.js Outdated Show resolved Hide resolved
resources/js/tags.js Outdated Show resolved Hide resolved
resources/views/entities/pages/inventory/_form.blade.php Outdated Show resolved Hide resolved
app/Http/Controllers/Entity/InventoryController.php Show resolved Hide resolved
@spitfire305
Copy link
Collaborator Author

spitfire305 commented May 13, 2024 •
edited

Does this work well with emojis and & signs in the position field?

Yeah, but

emojis are cringe

@spitfire305 spitfire305 requested a review from ilestis May 13, 2024 03:39
@ilestis ilestis merged commit 7990d2b into develop May 13, 2024
1 of 2 checks passed
@ilestis ilestis deleted the inventory-phase-2 branch May 13, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilestis ilestis ilestis approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@spitfire305 @ilestis