Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inventory phase 1 #868

Merged
merged 7 commits into from May 6, 2024
Merged

Inventory phase 1 #868

merged 7 commits into from May 6, 2024

Conversation

spitfire305
Copy link
Collaborator

No description provided.

@spitfire305 spitfire305 requested a review from ilestis May 3, 2024 17:16
ilestis
ilestis requested changes May 3, 2024
View reviewed changes
Copy link
Member

@ilestis ilestis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small tweaks for cleaner code

app/Http/Controllers/Entity/InventoryController.php Outdated Show resolved Hide resolved
app/Http/Controllers/Entity/InventoryController.php Outdated Show resolved Hide resolved
app/Http/Controllers/Entity/InventoryController.php Outdated Show resolved Hide resolved
app/Http/Controllers/Entity/InventoryController.php Outdated Show resolved Hide resolved
app/Http/Requests/CopyInventory.php Outdated Show resolved Hide resolved
app/Http/Requests/UpdateInventory.php Show resolved Hide resolved
lang/en/entities/inventories.php Outdated Show resolved Hide resolved
resources/views/entities/pages/inventory/_buttons.blade.php Outdated Show resolved Hide resolved
@spitfire305 spitfire305 requested a review from ilestis May 3, 2024 21:44
ilestis
ilestis requested changes May 6, 2024
View reviewed changes
Copy link
Member

@ilestis ilestis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not working as intended

app/Http/Controllers/Entity/CopyInventoryController.php Outdated Show resolved Hide resolved
app/Http/Controllers/Entity/InventoryController.php Outdated Show resolved Hide resolved
app/Http/Requests/StoreInventory.php Show resolved Hide resolved
@spitfire305 spitfire305 requested a review from ilestis May 6, 2024 17:07
ilestis
ilestis approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@ilestis ilestis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:chefkiss:

@ilestis ilestis merged commit 20f3b9d into develop May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilestis ilestis ilestis approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@spitfire305 @ilestis