test: Logical, syntax and cosmetic fixes on test cases #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airween
requested review from
mirkodziadzka-avi and
MirkoDziadzka
and removed request for
dune73,
MirkoDziadzka and
mirkodziadzka-avi
This reverts commit 80e2443.
|
airween
requested review from
marcstern
and removed request for
mirkodziadzka-avi
marcstern
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are a very important part of the library. While investigating an issue, I found some errors in the tests that could have led to false results, such as using a non-existent
@contaisoperator instead of@contains. This PR fixes these and some other cases.