Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed panic during output (should hopefully fix #800) #887

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

UFeindschiff
Copy link

Currently processOutput() is writing only references of the objects to output to the different output channels (text, json, print). However, the saveTextOutput() function actually modifies that data structure which causes a concurrent json marshal on the same data structure to panic as the data being marsheled is modified by another thread.

This PR proposes deep copies of the output objects being written into the different output channels as it seems to me to be the most sane solution.

The alternatives would have been to either have output mutex-locked, which would still have the disadvantage of saveTextOutput() modifying the data, so you would have a different output depending on whether or not saveTextOutput() happened to run prior or later than your current output as it modifies the data. The other alternative would have been to just modify saveTextOutput(), but that isn't future-proof as in the future someone might write a new output function or modify an existing one in a way that it modifies the data again which would cause everything to break all over again.

I know creating a deep copy through json.Marshal() and json.Unmarshal() is not the most elegant way of creating a deep copy, but it shouldn't cause too much overhead compared to writing functions to do that manually using reflections.

…f the result objects into the output channels
@UFeindschiff UFeindschiff changed the title Fixed panic during output #800 Fixed panic during output (should hopefully fix #800) Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant