Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(executor/redis): Redis auth (ACL) support #784

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bastienwirtz
Copy link

Hello,

Bump the redis client to the latest version to support ACL (introduced here)
Btw, the garyburd/redigo/redis has moved to gomodule/redigo/redis. The old repo is unmaintained.

Behavior

Test

- name: Test commands
  steps:
    - type: redis
      dialURL: "redis://{{.user}}:{{.password}}@localhost:6379/0"
      commands:
        - SET foo bar
        - GET foo
        - KEYS *
      assertions:
        - result.commands.commands0.response ShouldEqual OK
        - result.commands.commands1.response ShouldEqual bar
        - result.commands.commands2.response.response0 ShouldEqual foo

Current result

 	• Test-commands
 		• redis FAIL
 		  Testcase "Test commands", step #0-0: WRONGPASS invalid username-password pair or user is disabled.
final status: FAIL

New result

 	• Test-commands
 		• redis PASS
final status: PASS

Signed-off-by: Bastien Wirtz <bastien.wirtz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant