Increase coverage in assertions #732
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
… based on the documentation Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
sguiheux
approved these changes
Oct 23, 2023
yesnault
requested changes
Oct 23, 2023
Comment on lines
266
to
+268
| func ShouldNotExist(actual interface{}, expected ...interface{}) error { | ||
| if ShouldBeNil(actual) != nil || | ||
| ShouldBeBlank(actual) != nil || | ||
| ShouldBeZeroValue(actual) != nil { | ||
| return fmt.Errorf("expected not exist but it was") | ||
| if ShouldBeNil(actual) != nil && ShouldBeBlank(actual) != nil && ShouldBeZeroValue(actual) != nil { | ||
| return fmt.Errorf("expected to be empty but it was not") |
There was a problem hiding this comment.
Why do you need to update that ?
name: Assertions testsuite
testcases:
- name: test assertion ShouldNotExist
steps:
- script: echo ''
assertions:
- result.systemoutjson ShouldNotExist
-->
ShouldBeNil: expected: Nil but is wasn't
ShouldBeBlank: <nil>
ShouldBeZeroValue: <nil>
--> With your code, the testsuite is PASS, but should be be FAIL
There was a problem hiding this comment.
The documentation of this method specifies the following :
ShouldNotExist receives a single parameter and ensures that it is nil, blank or zero value
I added the parameterised test that checks all these and it was failing when the value was blank similar to the example that you specified. This is means that the method is not working to its specification ( needs to PASS when the value is blank ) , thus the amendment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding local json instead of trying to call an http server. Increasing coverage of assertions by adding tests in the
ShouldBeMap,ShouldBeArrayand fixing the issue with theShouldNotExist