feat: api: add a route to resolve a templating expression #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CDS Report test#1193.0 ✘
|
rbeuque74
force-pushed
the
dev/rbeuque/templating
branch
from
68e8d02
to
91b4374
Compare
wI2L
reviewed
Dec 24, 2021
rbeuque74
force-pushed
the
dev/rbeuque/templating
branch
from
91b4374
to
6f4349f
Compare
rclsilver
previously approved these changes
May 3, 2022
When debugging a failed task, we often need to resolve templated value that we struggle to inspect. POST /resolution/:id/templating will execute a templating expression given as input, and returns the resolved expression as output. This route can only be used by admins. Signed-off-by: Romain Beuque <556072+rbeuque74@users.noreply.github.com>
rclsilver
force-pushed
the
dev/rbeuque/templating
branch
from
6f4349f
to
c617897
Compare
Signed-off-by: Thomas Bétrancourt <thomas@betrancourt.net>
rclsilver
force-pushed
the
dev/rbeuque/templating
branch
from
c617897
to
7c898db
Compare
richardlt
approved these changes
May 6, 2022
|
Note: this route should be restricted to admin users, to avoid leaking sensitive informations from resolutions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the new behavior (if this is a feature change)?
When debugging a failed task, we often need to resolve templated value
that we struggle to inspect. POST /resolution/:id/templating will
execute a templating expression given as input, and returns the resolved
expression as output. This route can only be used by admins.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: