-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the wordpress example #44
base: main
Are you sure you want to change the base?
Conversation
yomovh
commented
Mar 14, 2024
- Add private network
- Update documentation to access to wordpress backoffice
Hi, First things, can you fix the conflicts? Also, I added several suggestions and remarks, please take a look at them. By the way, in the README file I recommend also to change "Mysql" to "MySQL" And, the most important, the example is currently not working for me, when I'm trying to deploy the Kubernetes cluster:
Thanks |
…mentation for network ressources
I have made a change in the content by removing as suggested the dependency towards openstack provider. The requested changes have normally been adressed (since I updated the content, I may have missed some). Thanks for the review. |
@yomovh can you clarify (by closing the request with a comment) when you don't want to apply @scraly's suggestion to have a more readable PR for people like me that comes at the end of the PR (this lets me know if the changes are completed or not). The main point mentioned by @scraly was that the code wasn't executing, is that fixed with your updates? |
Hello, @philippart-s As you suggested I also closed the comments that I took into account (see my comment) |
thanks, it's easier for me to valid the PR 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.