New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dedicated): add missing properties #11676
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipp972
previously approved these changes
May 10, 2024
qpavy
previously approved these changes
May 10, 2024
anooparveti
requested changes
May 10, 2024
packages/manager/apps/dedicated/client/app/network-security/traffic/traffic.controller.js
Show resolved
Hide resolved
antonymarion
force-pushed
the
fix/INC0035791
branch
from
May 10, 2024 13:13
0ce9d3c
to
98f8d1a
Compare
anooparveti
reviewed
May 10, 2024
packages/manager/apps/dedicated/client/app/network-security/traffic/traffic.controller.js
Outdated
Show resolved
Hide resolved
anooparveti
requested changes
May 10, 2024
packages/manager/apps/dedicated/client/app/network-security/traffic/traffic.routing.js
Outdated
Show resolved
Hide resolved
antonymarion
force-pushed
the
fix/INC0035791
branch
from
May 10, 2024 13:26
98f8d1a
to
805277d
Compare
antonymarion
force-pushed
the
fix/INC0035791
branch
from
May 10, 2024 13:28
805277d
to
19a5141
Compare
anooparveti
previously approved these changes
May 10, 2024
qpavy
previously approved these changes
May 10, 2024
antonymarion
changed the title
fix(dedicated): add missing stateParams
fix(dedicated): add missing properties
May 10, 2024
ghyenne
reviewed
May 13, 2024
packages/manager/apps/dedicated/client/app/network-security/traffic/traffic.routing.js
Show resolved
Hide resolved
antonymarion
force-pushed
the
fix/INC0035791
branch
from
May 13, 2024 07:37
19a5141
to
9468175
Compare
qpavy
previously approved these changes
May 13, 2024
ghyenne
reviewed
May 13, 2024
packages/manager/apps/dedicated/client/app/network-security/traffic/traffic.component.js
Outdated
Show resolved
Hide resolved
ref: INC0035791 Signed-off-by: Antony MARION <antony.marion.ext@ovhcloud.com>
antonymarion
force-pushed
the
fix/INC0035791
branch
from
May 13, 2024 08:16
9468175
to
689e2e8
Compare
Quality Gate passedIssues Measures |
MaximeBajeux
approved these changes
May 14, 2024
8 tasks
darsene
reviewed
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is in double -> #11694
packages/manager/apps/dedicated/client/app/network-security/traffic/traffic.routing.js
Show resolved
Hide resolved
darsene
approved these changes
May 14, 2024
this page should also be accessible with direct link, please see @Steffy29 PR instead for both fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: INC0035791
master
- [ ] Only FR translations have been updated- [ ] Breaking change is mentioned in relevant commitsDescription
DDOS chart was not appearing
Related