Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dedicated): add missing properties #11676

Closed
wants to merge 1 commit into from
Closed

Conversation

antonymarion
Copy link
Contributor

@antonymarion antonymarion commented May 10, 2024

ref: INC0035791

Question Answer
Branch? master
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix#INC0035791
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
    - [ ] Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
    - [ ] Breaking change is mentioned in relevant commits

Description

DDOS chart was not appearing

Related

@antonymarion antonymarion requested a review from a team as a code owner May 10, 2024 12:59
@github-actions github-actions bot added universe-bare-metal-cloud bug Something isn't working labels May 10, 2024
chipp972
chipp972 previously approved these changes May 10, 2024
qpavy
qpavy previously approved these changes May 10, 2024
anooparveti
anooparveti previously approved these changes May 10, 2024
qpavy
qpavy previously approved these changes May 10, 2024
@antonymarion antonymarion changed the title fix(dedicated): add missing stateParams fix(dedicated): add missing properties May 10, 2024
qpavy
qpavy previously approved these changes May 13, 2024
@antonymarion antonymarion requested a review from ghyenne May 13, 2024 08:01
  ref: INC0035791

Signed-off-by: Antony MARION <antony.marion.ext@ovhcloud.com>
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@darsene darsene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is in double -> #11694

@antonymarion antonymarion requested a review from darsene May 14, 2024 08:19
@antonymarion
Copy link
Contributor Author

this page should also be accessible with direct link, please see @Steffy29 PR instead for both fixes

@anooparveti anooparveti deleted the fix/INC0035791 branch May 20, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working universe-bare-metal-cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants