feat(dedicated): add modal for ipv6 on vrack #11675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: MANAGER-13850 Signed-off-by: mhalheli soufien <mhalheli.soufien@gmail.com>
mhelhali-soufien
requested review from
qpavy,
antonymarion and
JacquesLarique
and removed request for
a team
github-actions
bot
added
universe-bare-metal-cloud
translation required
feature
qpavy
approved these changes
May 10, 2024
anooparveti
requested changes
May 14, 2024
anooparveti
requested changes
May 16, 2024
| @@ -11,9 +11,13 @@ | |||
| "vrack__assigned-ipv6__subnet_delete_title": "Retirer le sous réseau de votre vRack", | |||
| "vrack__assigned-ipv6__subnet_delete_description": "Confirmez-vous vouloir retirer le sous réseau de votre vRack ?", | |||
| "vrack__assigned-ipv6_subnet_via": "{{ ipblock }} via {{ ip }} ", | |||
| "vrack_add_ipv6_modal_title": "Ajouter un IP block dans le vRack", | |||
| "vrack_add_ipv6_modal_description": "Vous allez ajouter un bloc IP : <strong>{{ ipblock }}</strong> (situé dans <strong>{{ region }}</strong>) dans votre vRack : <strong>{{ vrack }}</strong> <br> Cette action permettra d'atteindre les machines situées dans ce vRack depuis l'internet public.<br>Le trafic public sera routé à travers la région <strong>{{ region }}</strong>.<br>Pour plus d'information, veuillez consulter", | |||
There was a problem hiding this comment.
nitpick: Avoid HTML in translation files. Instead include the HTML tags in the data-translate-values.
Suggested change
| "vrack_add_ipv6_modal_description": "Vous allez ajouter un bloc IP : <strong>{{ ipblock }}</strong> (situé dans <strong>{{ region }}</strong>) dans votre vRack : <strong>{{ vrack }}</strong> <br> Cette action permettra d'atteindre les machines situées dans ce vRack depuis l'internet public.<br>Le trafic public sera routé à travers la région <strong>{{ region }}</strong>.<br>Pour plus d'information, veuillez consulter", | |
| "vrack_add_ipv6_modal_description": "Vous allez ajouter un bloc IP : {{ ipblock }} (situé dans {{ region }}) dans votre vRack :{{ vrack }} <br> Cette action permettra d'atteindre les machines situées dans ce vRack depuis l'internet public.<br>Le trafic public sera routé à travers la région {{ region }}.<br>Pour plus d'information, veuillez consulter", |
| @@ -11,9 +11,13 @@ | |||
| "vrack__assigned-ipv6__subnet_delete_title": "Retirer le sous réseau de votre vRack", | |||
| "vrack__assigned-ipv6__subnet_delete_description": "Confirmez-vous vouloir retirer le sous réseau de votre vRack ?", | |||
| "vrack__assigned-ipv6_subnet_via": "{{ ipblock }} via {{ ip }} ", | |||
| "vrack_add_ipv6_modal_title": "Ajouter un IP block dans le vRack", | |||
| "vrack_add_ipv6_modal_description": "Vous allez ajouter un bloc IP : <strong>{{ ipblock }}</strong> (situé dans <strong>{{ region }}</strong>) dans votre vRack : <strong>{{ vrack }}</strong> <br> Cette action permettra d'atteindre les machines situées dans ce vRack depuis l'internet public.<br>Le trafic public sera routé à travers la région <strong>{{ region }}</strong>.<br>Pour plus d'information, veuillez consulter", | |||
There was a problem hiding this comment.
nitpick: Avoid break lines in translations by splitting into multiple messages.
github-actions
bot
added
has conflicts
|
anooparveti
approved these changes
May 17, 2024
mhelhali-soufien
merged commit 1a0f780
into
feat/additional-ipv6-feature
12 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat/additional-ipv6-featureOnly FR translations have been updatedBreaking change is mentioned in relevant commitsDescription
Related