Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dedicated): pcc ip blocks label #11674

Merged
merged 2 commits into from May 15, 2024
Merged

fix(dedicated): pcc ip blocks label #11674

merged 2 commits into from May 15, 2024

Conversation

qpavy
Copy link
Contributor

@qpavy qpavy commented May 10, 2024

Question Answer
Branch? develop
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #PRB0041074
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • [ ] Breaking change is mentioned in relevant commits

Description

Related

@qpavy qpavy requested a review from a team as a code owner May 10, 2024 11:24
@github-actions github-actions bot added universe-bare-metal-cloud translation required dependencies Pull requests that update a dependency file bug Something isn't working labels May 10, 2024
@qpavy
fix(dedicated): fix pcc label
06ef030 
ref: PRB0041074

Signed-off-by: Quentin Pavy <contact@quentinpavy.com>
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label May 10, 2024
anooparveti
anooparveti previously approved these changes May 10, 2024
View reviewed changes
MaximeBajeux
MaximeBajeux previously approved these changes May 10, 2024
View reviewed changes
JacquesLarique
JacquesLarique previously approved these changes May 10, 2024
View reviewed changes
chipp972
chipp972 previously approved these changes May 10, 2024
View reviewed changes
@qpavy
fix(dedicated): fix pcc label ca
5fde13f 
ref: PRB0041074

Signed-off-by: Quentin Pavy <contact@quentinpavy.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@anooparveti anooparveti merged commit 94ed6cc into develop May 15, 2024
13 of 15 checks passed
@anooparveti anooparveti deleted the fix/PRB0041074 branch May 15, 2024 14:19
@darsene darsene mentioned this pull request May 17, 2024
Merged
18 tasks
sidlynx pushed a commit that referenced this pull request May 21, 2024
@qpavy @sidlynx
fix(dedicated): pcc ip blocks label (#11674)
5ef135d 
ref: PRB0041074

Signed-off-by: Quentin Pavy <contact@quentinpavy.com>
sidlynx pushed a commit that referenced this pull request May 21, 2024
@qpavy @sidlynx
fix(dedicated): pcc ip blocks label (#11674)
dd60ce1 
ref: PRB0041074

Signed-off-by: Quentin Pavy <contact@quentinpavy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaximeBajeux MaximeBajeux MaximeBajeux approved these changes

@chipp972 chipp972 chipp972 approved these changes

@anooparveti anooparveti anooparveti approved these changes

@JacquesLarique JacquesLarique JacquesLarique left review comments

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne is a code owner automatically assigned from ovh/team-manager-dev

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn is a code owner automatically assigned from ovh/team-manager-dev

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien is a code owner automatically assigned from ovh/team-manager-dev

Assignees
No one assigned
Labels
bug Something isn't working quality check: ok universe-bare-metal-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@qpavy @MaximeBajeux @chipp972 @anooparveti @JacquesLarique