Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rancher): use component from manager component #11668

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat(rancher): use component from manager component #11668

wants to merge 1 commit into from

Conversation

lionel95200x
Copy link
Contributor

@lionel95200x lionel95200x commented May 7, 2024 •
edited

ref: MANAGER-14286

Question Answer
Branch? develop
Bug fix? no
New feature? no
Breaking change? no
Tickets Fix #MANAGER-14286
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Use component from manager components

Related

@lionel95200x lionel95200x requested review from a team as code owners May 7, 2024 12:47
@github-actions github-actions bot added dependencies Pull requests that update a dependency file feature New feature labels May 7, 2024
@lionel95200x lionel95200x force-pushed the feat/MANAGER-14286-use-component-manager-rancher branch from 920823d to c84a108 Compare May 7, 2024 13:22
@lionel95200x lionel95200x force-pushed the feat/MANAGER-14286-use-component-manager-rancher branch from c84a108 to 374d281 Compare May 13, 2024 10:10
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label May 13, 2024
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label May 16, 2024
@lionel95200x lionel95200x force-pushed the feat/MANAGER-14286-use-component-manager-rancher branch from 374d281 to a5b7f77 Compare May 20, 2024 13:25
@lionel95200x
feat: use components manager in rancher
b630471 
ref: MANAGER-14286

Signed-off-by: Lio <lionel95200@gmail.com>
@lionel95200x lionel95200x force-pushed the feat/MANAGER-14286-use-component-manager-rancher branch from a5b7f77 to b630471 Compare May 21, 2024 09:21
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label May 21, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anooparveti anooparveti anooparveti requested changes

@chipp972 chipp972 chipp972 approved these changes

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux is a code owner automatically assigned from ovh/team-manager-dev

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss is a code owner automatically assigned from ovh/team-manager-dev

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
feature New feature has conflicts Has conflicts to resolve before merging manager-components universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lionel95200x @chipp972 @anooparveti