Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci-rancher): define version of a rancher #11666

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat(pci-rancher): define version of a rancher #11666

wants to merge 2 commits into from

Conversation

selm3n
Copy link

@selm3n selm3n commented May 7, 2024

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #TAPC-833
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

feat(pci.rancher): define version of a rancher
44148cf 
ref: TAPC-833
Signed-off-by: Selmen AKRMI <selmen.akrmi.ext@ovhcloud.com>
@selm3n selm3n requested review from a team as code owners May 7, 2024 09:47
@selm3n selm3n changed the base branch from master to develop May 7, 2024 09:48
anooparveti
anooparveti requested changes May 8, 2024
View reviewed changes
Copy link
Contributor

@anooparveti anooparveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the scope of the commit from pci.rancher to pci-rancher

@selm3n selm3n changed the title feat(pci.rancher): define version of a rancher feat(pci-rancher): define version of a rancher May 10, 2024
anooparveti
anooparveti previously approved these changes May 15, 2024
View reviewed changes
feat(pci-rancher): add tests
6cf8ce1 
ref: TAPC-833
Signed-off-by: Selmen AKRMI <selmen.akrmi.ext@ovhcloud.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionel95200x lionel95200x lionel95200x approved these changes

@anooparveti anooparveti anooparveti approved these changes

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion is a code owner automatically assigned from ovh/team-manager-dev

@darsene darsene Awaiting requested review from darsene darsene is a code owner automatically assigned from ovh/team-manager-dev

Assignees
No one assigned
Labels
feature New feature quality check: ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@selm3n @lionel95200x @anooparveti