feat(dedicated): add slaac option to vrack ipv6 block #11663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: MANAGER-13715 Signed-off-by: mhalheli soufien <mhalheli.soufien@gmail.com>
mhelhali-soufien
requested review from
qpavy,
MaximeBajeux and
anooparveti
and removed request for
a team
| data-ng-bind="::bridged.bridgedSubrange" | ||
| ></span> | ||
| <span | ||
| >SLAAC |
There was a problem hiding this comment.
SLAAC is not in a constants file?
| @@ -21,7 +21,33 @@ export default class VrackAssignedIpCtrl { | |||
| } | |||
|
|
|||
| $onInit() { | |||
| this.refreshData(); | |||
| this.vrackAssignedIpv6Service | |||
There was a problem hiding this comment.
should bridgedSubranges be instead in the resolve of the routing file?
There was a problem hiding this comment.
Nop because this component is not loaded at the init of the page doing like this allow to make the call only when we open the ipv6 detail
qpavy
reviewed
May 10, 2024
| &__sub-item { | ||
| display: flex; | ||
| justify-content: end; | ||
| flex-flow: wrap; | ||
| } | ||
|
|
||
| &__subnet { | ||
| &__subnet, | ||
| &__subrang { |
There was a problem hiding this comment.
Suggested change
| &__subrang { | |
| &__subrange { |
| @@ -8,14 +8,61 @@ | |||
| <span data-translate="vrack__assigned-ipv6_add_subnet"></span> | |||
| </button> | |||
| </div> | |||
| <!-- subridg --> | |||
| <li | |||
| class="vrack__assigned-ipv6__subrang" | |||
There was a problem hiding this comment.
Suggested change
| class="vrack__assigned-ipv6__subrang" | |
| class="vrack__assigned-ipv6__subrange" |
| data-ng-bind="::bridged.bridgedSubrange" | ||
| ></span> | ||
| <span | ||
| >SLAAC |
There was a problem hiding this comment.
Suggested change
| >SLAAC | |
| >$ctrl.label.SLAAC |
Put this in constant file
| <oui-switch | ||
| data-ng-hide="bridged.loading" | ||
| model="bridged.model" | ||
| on-change="$ctrl.toggleSubrang(bridged)" |
There was a problem hiding this comment.
Suggested change
| on-change="$ctrl.toggleSubrang(bridged)" | |
| on-change="$ctrl.toggleSubrange(bridged)" |
| ></button> | ||
| <script | ||
| type="text/ng-template" | ||
| id="vrack__assigned-ipv6__subrang_slaac_help.html" |
There was a problem hiding this comment.
Suggested change
| id="vrack__assigned-ipv6__subrang_slaac_help.html" | |
| id="vrack__assigned-ipv6__subrange_slaac_help.html" |
| id="vrack__assigned-ipv6__subrang_slaac_help.html" | ||
| > | ||
| <p | ||
| data-translate="vrack__assigned-ipv6__subrang_slaac_help" |
There was a problem hiding this comment.
Suggested change
| data-translate="vrack__assigned-ipv6__subrang_slaac_help" | |
| data-translate="vrack_assigned_ipv6_subrange_slaac_help" |
| @@ -61,6 +90,34 @@ export default class VrackAssignedIpCtrl { | |||
| }; | |||
| } | |||
|
|
|||
| toggleSubrang(bridgedSubrange) { | |||
There was a problem hiding this comment.
Suggested change
| toggleSubrang(bridgedSubrange) { | |
| toggleSubrange(bridgedSubrange) { |
| data-ng-repeat="bridged in $ctrl.bridgedSubranges track by $index" | ||
| > | ||
| <span | ||
| class="vrack__assigned-ipv6__subrang__title" |
There was a problem hiding this comment.
Suggested change
| class="vrack__assigned-ipv6__subrang__title" | |
| class="vrack__assigned-ipv6__subrange__title" |
| <a | ||
| class="oui-link_icon" | ||
| aria-hidden="true" | ||
| data-ng-href="{{$ctrl.localZoneUrl}}" |
| > | ||
| <span class="oui-icon oui-icon-book ml-0" aria-hidden="true"></span> | ||
| <span | ||
| data-translate="vrack__assigned-ipv6__subrang_slaac_help_tooltip_link" |
There was a problem hiding this comment.
Suggested change
| data-translate="vrack__assigned-ipv6__subrang_slaac_help_tooltip_link" | |
| data-translate="vrack_assigned_ipv6_subrange_slaac_help_tooltip_link" |
|
qpavy
approved these changes
May 14, 2024
antonymarion
approved these changes
May 14, 2024
mhelhali-soufien
merged commit 1f1a214
into
feat/additional-ipv6-feature
12 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat/additional-ipv6-featureOnly FR translations have been updatedBreaking change is mentioned in relevant commitsDescription
Related