Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hub): ticket appears even cancelled #11662

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MaximeBajeux
Copy link
Contributor

Question Answer
Branch? master
Bug fix? yes
New feature? no
Breaking change? no
Tickets MANAGER-13862
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • [] Breaking change is mentioned in relevant commits (n/a)

Description

Remove cache for tickets in dashboard

Related

@MaximeBajeux MaximeBajeux requested a review from a team as a code owner May 7, 2024 06:34
@github-actions github-actions bot added universe-hub bug Something isn't working labels May 7, 2024
remove cache for tickets

ref: MANAGER-13862

Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Does the 2API supports or forwards the headers to the underlying APIv6 call?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the 2api side, cache is handle for all the hub and it seems we can't override the behaviour without refactoring for all the hub. I tested and it seems the fix works well. Do you have another solution in head ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems there is no cache between apiV6 and 2api, so normally I think we not need to forward the headers to api V6 because the cache exists only between the 2api and the manager. About the performance cost, obviously that costs one API call each time the service is call. To reduce the performance issue, we could get only the two latest tickets from API instead of getting all and truncate into the 2api, like in the bff. But this is something that will be resolved once the bff is in production.

oalkabouss
oalkabouss previously approved these changes May 15, 2024
try to refresh cache when cancel

ref: MANAGER-13862

Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
This reverts commit 6028d8a.

ref: fix/MANAGER-13862
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working universe-hub
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants