New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hub): ticket appears even cancelled #11662
base: master
Are you sure you want to change the base?
Conversation
remove cache for tickets ref: MANAGER-13862 Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Does the 2API supports or forwards the headers to the underlying APIv6 call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the 2api side, cache is handle for all the hub and it seems we can't override the behaviour without refactoring for all the hub. I tested and it seems the fix works well. Do you have another solution in head ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems there is no cache between apiV6 and 2api, so normally I think we not need to forward the headers to api V6 because the cache exists only between the 2api and the manager. About the performance cost, obviously that costs one API call each time the service is call. To reduce the performance issue, we could get only the two latest tickets from API instead of getting all and truncate into the 2api, like in the bff. But this is something that will be resolved once the bff is in production.
try to refresh cache when cancel ref: MANAGER-13862 Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
877b76e
to
6028d8a
Compare
This reverts commit 6028d8a. ref: fix/MANAGER-13862
Quality Gate passedIssues Measures |
master
Description
Remove cache for tickets in dashboard
Related