fix(pci-public-ip): add marging the button action in all datagrid #11650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: DTCORE-2188 Signed-off-by: LIDRISSI Hamid <abdelghani-lidrissi.hamid.ext@ovhcloud.com>
seven-amid
requested review from
kqesar and
frenautvh
and removed request for
a team
|
frenautvh
approved these changes
May 7, 2024
ghyenne
approved these changes
May 13, 2024
| @@ -132,7 +132,9 @@ export default function FailoverIPComponent({ | |||
| { | |||
| id: 'actions', | |||
| cell: (props: FailoverIP) => ( | |||
| <FailoverIPActions projectId={projectId} ipId={props.id} /> | |||
| <div className="min-w-16"> | |||
There was a problem hiding this comment.
Not mandatory but the React best practice would to create a small Wrapper <Cell> around your component to share the same style
chipp972
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: DTCORE-2188
Description
Related