feat(dedicated): remove paymentmean deprecated call #11642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: MANAGER-12850 Signed-off-by: benjaminlepine <benjamin.lepine@hotmail.fr>
github-actions
bot
added
universe-web-cloud
universe-bare-metal-cloud
universe-public-cloud
feature
| this.getValidPaymentMethodIds = function getValidPaymentMethodIds() { | ||
| return $http | ||
| .get(`${constants.swsProxyRootPath}me/payment/method`) | ||
| .then((response) => response.data); |
There was a problem hiding this comment.
You can directly do:
Suggested change
| .then((response) => response.data); | |
| .then(({ data }) => data); |
change request ref: feat/MANAGER-12850 Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
|
JacquesLarique
approved these changes
May 7, 2024
sachinrameshn
approved these changes
May 7, 2024
anooparveti
approved these changes
May 8, 2024
18 tasks
sidlynx
pushed a commit
that referenced
this pull request
May 21, 2024
ref: MANAGER-12850 Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
sidlynx
pushed a commit
that referenced
this pull request
May 21, 2024
ref: MANAGER-12850 Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterDescription
remove paymentmean deprecated call
Related
Recreation of: #10758