Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(telecom): send softphone app link by mail #11638

Draft
wants to merge 1 commit into
base: feat/softphone
Choose a base branch
from
Draft

feat(telecom): send softphone app link by mail #11638

wants to merge 1 commit into from

Conversation

antonymarion
Copy link
Contributor

@antonymarion antonymarion commented May 3, 2024 •
edited

ref: MANAGER-14010

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets Feat#MANAGER-14010
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
    - [ ] Breaking change is mentioned in relevant commits

Description

Related

feat(telecom): send app link by email
5f88b45 
  ref: MANAGER-14010

Signed-off-by: Antony MARION <antony.marion.ext@ovhcloud.com>
@antonymarion antonymarion requested a review from a team as a code owner May 3, 2024 15:42
@antonymarion antonymarion requested review from MaximeBajeux, oalkabouss and anooparveti and removed request for a team May 3, 2024 15:42
@antonymarion antonymarion marked this pull request as draft May 3, 2024 15:42
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux is a code owner automatically assigned from ovh/team-manager-dev

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss is a code owner automatically assigned from ovh/team-manager-dev

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti is a code owner automatically assigned from ovh/team-manager-dev

Assignees
No one assigned
Labels
feature New feature has conflicts Has conflicts to resolve before merging translation required universe-telecom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@antonymarion