feat(dedicated.nutanix): display error message with operations ongoing #11634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dectotam
force-pushed
the
feat/MANAGER-13446
branch
from
2f53d24
to
c8b7465
Compare
mhelhali-soufien
previously approved these changes
May 3, 2024
antonymarion
reviewed
May 3, 2024
packages/manager/modules/nutanix/src/dashboard/nodes/node/general-info/routing.js
Outdated
Show resolved
Hide resolved
darsene
reviewed
May 3, 2024
...manager/modules/bm-server-components/src/order-private-bandwidth/private-order.controller.js
Outdated
Show resolved
Hide resolved
packages/manager/modules/nutanix/src/dashboard/nodes/node/general-info/routing.js
Outdated
Show resolved
Hide resolved
chipp972
previously approved these changes
May 3, 2024
dectotam
force-pushed
the
feat/MANAGER-13446
branch
from
c8b7465
to
3717ee0
Compare
darsene
reviewed
May 3, 2024
...manager/modules/bm-server-components/src/order-private-bandwidth/private-order.controller.js
Show resolved
Hide resolved
...manager/modules/bm-server-components/src/order-private-bandwidth/private-order.controller.js
Show resolved
Hide resolved
...manager/modules/bm-server-components/src/order-private-bandwidth/private-order.controller.js
Show resolved
Hide resolved
anooparveti
requested changes
May 3, 2024
Comment on lines
15
to
23
| $state.go('^'); | ||
|
|
||
| if (scrollToTop) { | ||
| $timeout(() => { | ||
| const element = document.getElementById('nutanix_dashboard_node'); | ||
| if (element) { | ||
| element.scrollIntoView({ behavior: 'smooth', block: 'start' }); | ||
| } | ||
| }, 300); |
There was a problem hiding this comment.
nitpick: Instead of $timeout, rely on the promise returned by $state.go().
Suggested change
| $state.go('^'); | |
| if (scrollToTop) { | |
| $timeout(() => { | |
| const element = document.getElementById('nutanix_dashboard_node'); | |
| if (element) { | |
| element.scrollIntoView({ behavior: 'smooth', block: 'start' }); | |
| } | |
| }, 300); | |
| $state.go('^').then(() => { | |
| if (scrollToTop) { | |
| const element = document.getElementById('nutanix_dashboard_node'); | |
| element?.scrollIntoView({ behavior: 'smooth', block: 'start' }); | |
| } | |
| }); |
ref: MANAGER-13446 Signed-off-by: Amandine Dectot <amandine.dectot.ext@corp.ovh.com>
dectotam
force-pushed
the
feat/MANAGER-13446
branch
from
3717ee0
to
e8f6937
Compare
|
darsene
reviewed
May 13, 2024
packages/manager/modules/nutanix/src/dashboard/nodes/node/general-info/routing.js
Show resolved
Hide resolved
darsene
approved these changes
May 13, 2024
anooparveti
approved these changes
May 13, 2024
18 tasks
darsene
pushed a commit
that referenced
this pull request
May 17, 2024
#11634) ref: MANAGER-13446 Signed-off-by: Amandine Dectot <amandine.dectot.ext@corp.ovh.com>
sidlynx
pushed a commit
that referenced
this pull request
May 21, 2024
#11634) ref: MANAGER-13446 Signed-off-by: Amandine Dectot <amandine.dectot.ext@corp.ovh.com>
sidlynx
pushed a commit
that referenced
this pull request
May 21, 2024
#11634) ref: MANAGER-13446 Signed-off-by: Amandine Dectot <amandine.dectot.ext@corp.ovh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only FR translations have been updatedBreaking change is mentioned in relevant commitsDescription
Related