feat(pci-private-network): add the delete modal/action for global reg… #11632
Conversation
seven-amid
requested review from
kqesar,
frenautvh,
dectotam,
darsene and
mhelhali-soufien
and removed request for
a team
seven-amid
force-pushed
the
feat/DTCORE-2080
branch
3 times, most recently
from
fa38b60
to
557eef3
Compare
| import { TGateway, TRegion } from '@/api/data/project'; | ||
| import { getSubnets, TSubnet } from '@/api/data/subnets'; | ||
| import { | ||
| getLocalZoneRegions, | ||
| isLocalZoneRegion, | ||
| paginateResults, | ||
| } from '@/api/utils/utils'; | ||
| import queryClient from '@/queryClient'; |
There was a problem hiding this comment.
Don't import queryClient, use the useQueryClient hook
You will create a new instance, not use the one in the context
There was a problem hiding this comment.
this one is imported from a file defining one instance client
import { QueryClient } from '@tanstack/react-query';
export const queryClient = new QueryClient({
defaultOptions: {
queries: {
staleTime: 300_000,
},
},
});
export default queryClient;
There was a problem hiding this comment.
Ok but it still does not look like a good practice to import queryClient directly, even if it works
Using the queryClient from the context is safer imo
https://tanstack.com/query/latest/docs/framework/react/reference/useQueryClient#usequeryclient
Do you think there is any drawbacks to using useQueryClient hook to take it from the context ?
packages/manager/apps/pci-private-network/src/api/hooks/useNetwork.ts
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-private-network/src/components/delete/DeleteModal.component.tsx
Outdated
Show resolved
Hide resolved
…ions and local zones ref: DTCORE-2078 ref: DTCORE-2080 Signed-off-by: LIDRISSI Hamid <abdelghani-lidrissi.hamid.ext@ovhcloud.com>
seven-amid
force-pushed
the
feat/DTCORE-2080
branch
from
557eef3
to
f30e5a1
Compare
|
Description
Related