Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(key-management-service): add guides in header page template #11630

Merged
merged 4 commits into from May 15, 2024
Merged

feat(key-management-service): add guides in header page template #11630

merged 4 commits into from May 15, 2024

Conversation

darsene
Copy link
Contributor

@darsene darsene commented May 3, 2024

ref: MANAGER-13983

Question Answer
Branch? key-management-service
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-13983
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@darsene darsene requested review from a team as code owners May 3, 2024 10:28
@darsene darsene requested review from kqesar, frenautvh, ghyenne, sachinrameshn and JacquesLarique and removed request for a team May 3, 2024 10:28
@darsene darsene force-pushed the feat/MANAGER-13983 branch 2 times, most recently from 1d9e272 to 4d35b12 Compare May 3, 2024 12:07
@darsene darsene force-pushed the feat/MANAGER-13983 branch 2 times, most recently from 1adf4a9 to 6eae27b Compare May 3, 2024 15:59
@darsene darsene requested a review from chipp972 May 6, 2024 10:04
chipp972
chipp972 requested changes May 10, 2024
View reviewed changes
Copy link
Contributor

@chipp972 chipp972 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on develop to avoid duplicating i18n config in the project

@vovh vovh force-pushed the feat/key-management-service branch from 1c56612 to 415a228 Compare May 14, 2024 12:38
@github-actions github-actions bot added has conflicts Has conflicts to resolve before merging labels May 14, 2024
@vovh vovh force-pushed the feat/key-management-service branch from 415a228 to cc4333f Compare May 14, 2024 13:12
@darsene darsene force-pushed the feat/MANAGER-13983 branch 2 times, most recently from 7ed9ac9 to b185614 Compare May 14, 2024 13:27
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label May 14, 2024
@vovh vovh force-pushed the feat/key-management-service branch from cc4333f to a1ffd47 Compare May 14, 2024 15:05
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label May 14, 2024
@chipp972 chipp972 force-pushed the feat/key-management-service branch from a1ffd47 to 403c833 Compare May 15, 2024 08:19
@darsene
feat(key-management-service): add guides in header page template
9f4286f 
ref: MANAGER-13983

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
@darsene
fix(key-management-service): fix PR feedback
13363e0 
ref: MANAGER-13983

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label May 15, 2024
fix(key-management-service): fix i18n setup
b861a55 
ref: MANAGER-13983

Signed-off-by: Nicolas Pierre-charles <nicolas.pierre-charles.ext@corp.ovh.com>
@vovh @darsene
feat(*): add kms onboarding page
fc37a03 
ref: MANAGER-13826

Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@darsene darsene merged commit eae9871 into feat/key-management-service May 15, 2024
11 of 13 checks passed
@darsene darsene deleted the feat/MANAGER-13983 branch May 15, 2024 10:20
vovh pushed a commit that referenced this pull request May 15, 2024
@darsene @vovh
feat(key-management-service): add guides in header page template (#11630
226ac2c 
)


ref: MANAGER-13983

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipp972 chipp972 chipp972 approved these changes

@JacquesLarique JacquesLarique JacquesLarique approved these changes

@vovh vovh vovh approved these changes

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne is a code owner automatically assigned from ovh/team-manager-dev

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn is a code owner automatically assigned from ovh/team-manager-dev

Assignees
No one assigned
Labels
feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@darsene @chipp972 @JacquesLarique @vovh