Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware-Hosted-Private-Cloud-VCD - Adding-changes-to-one-branch-for-review #6254

Closed
wants to merge 3 commits into from
Closed

VMware-Hosted-Private-Cloud-VCD - Adding-changes-to-one-branch-for-review #6254

wants to merge 3 commits into from

Conversation

BrenKt
Copy link
Contributor

@BrenKt BrenKt commented Apr 30, 2024

No description provided.

@BrenKt
Copy link
Contributor Author

BrenKt commented Apr 30, 2024 •
edited

  • Content FR reviewed
  • GIFs to resize
  • EN translation to do after FR validation

@BrenKt BrenKt marked this pull request as draft April 30, 2024 14:12
@BrenKt
Copy link
Contributor Author

BrenKt commented Apr 30, 2024

⚠️ Work in progress, review to redo after validation ⚠️

pg-ovh
pg-ovh reviewed May 9, 2024
View reviewed changes
...sted_private_cloud/hosted_private_cloud_powered_by_vmware/vcd-getting-started/guide.fr-fr.md Outdated
- Avoir un compte VMware Cloud Director
- Une connaissance pratique des réseaux Linux, vSphere, Windows et IP est nécessaire pour configurer et gérer vCD
- Avoir un compte VMware Cloud Director administrateur
- Avoir une infrastructure VMware Cloud Foundation (VCF)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @franckcosta est-ce que j'enlève cette ligne (20) en réf à "VCF" pour l'instant ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oui

@pg-ovh pg-ovh self-assigned this May 10, 2024
@pg-ovh pg-ovh marked this pull request as ready for review May 14, 2024 07:36
OVH-Team-Guides
OVH-Team-Guides reviewed May 14, 2024
View reviewed changes
...sted_private_cloud/hosted_private_cloud_powered_by_vmware/vcd-getting-started/guide.fr-fr.md Outdated

![Dashboard Overview](images/vcd-dashboard-overview.png){.thumbnail}

Les différentes sections disponibles :
<details>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pg-ovh , I suggest you remove all the <details> formats from this guide as they are not necessary.

If they were to be kept, they would need fixes as there are too many <summary> tags and all included content has to be formatted in HTML too, as in https://help.ovhcloud.com/csm/fr-vmware-nsx-interface-user-access?id=kb_article_view&sysparm_article=KB0062999 (see formats in https://github.com/ovh/docs/blob/develop/pages/hosted_private_cloud/hosted_private_cloud_powered_by_vmware/nsx_add_user_rights/guide.fr-fr.md?plain=1)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OVH-Team-Guides also from the en-gb guide ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please

@OVH-Team-Guides OVH-Team-Guides changed the title BrenKt--VMware-Hosted-Private-Cloud---VCD]---SK1520/21/22---Adding-changes-to-one-branch-for-review VMware-Hosted-Private-Cloud-VCD - SK1520/21/22 - Adding-changes-to-one-branch-for-review May 15, 2024
@pg-ovh pg-ovh changed the title VMware-Hosted-Private-Cloud-VCD - SK1520/21/22 - Adding-changes-to-one-branch-for-review VMware-Hosted-Private-Cloud-VCD - Adding-changes-to-one-branch-for-review May 16, 2024
@OVH-Team-Guides OVH-Team-Guides added the Edition needed Content needs edition from the author before Quality Check by the Guides Team can start/resume label May 16, 2024
@pg-ovh pg-ovh force-pushed the BrenKt--VMware-Hosted-Private-Cloud---VCD]---SK1520/21/22---Adding-changes-to-one-branch-for-review branch from 19e908c to bb9d5be Compare May 22, 2024 07:26
@pg-ovh
Copy link
Contributor

pg-ovh commented May 22, 2024 •
edited

Hello @OVH-Team-Guides I have removed the changes made without any formatting, let me know if you need more help on this PR. Edition done.

@pg-ovh pg-ovh force-pushed the BrenKt--VMware-Hosted-Private-Cloud---VCD]---SK1520/21/22---Adding-changes-to-one-branch-for-review branch from bb9d5be to 4bcb8b1 Compare May 22, 2024 07:42
@pg-ovh
Copy link
Contributor

pg-ovh commented May 22, 2024

Hello @OVH-Team-Guides, I seem to have broken the folder structure by trying to merge my local conflicts. I have informed @tcpdumpfbacke in pm. Let me know if you need my local changes from this commit : https://github.com/ovh/docs/compare/19e908c87953faeed91e815b516a5d398e04510a..bb9d5be306755023bd80156c05d526a4a071b517
Sorry for the inconvenience.

@tcpdumpfbacke tcpdumpfbacke force-pushed the BrenKt--VMware-Hosted-Private-Cloud---VCD]---SK1520/21/22---Adding-changes-to-one-branch-for-review branch from a53997f to 4bcb8b1 Compare May 22, 2024 11:21
@pg-ovh pg-ovh mentioned this pull request May 22, 2024
Merged
@OVH-Team-Guides
Copy link
Collaborator

Replaced by #6349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OVH-Team-Guides OVH-Team-Guides OVH-Team-Guides left review comments

@franckcosta franckcosta franckcosta left review comments

@pg-ovh pg-ovh pg-ovh left review comments

Assignees

@pg-ovh pg-ovh

Labels
Edition needed Content needs edition from the author before Quality Check by the Guides Team can start/resume
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BrenKt @pg-ovh @OVH-Team-Guides @franckcosta