New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mongoinit to fix initial docker-compose file #1218
base: main
Are you sure you want to change the base?
Conversation
Reason: Merge exists on branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea this gets at. I don't know enough MongoDB (yet) to fully back this. That being said, I didn't see anything that looks obviously dangerous to merge--except if you do not squash it might not as clean of a merge.
@@ -1,4 +1,3 @@ | |||
version: '2.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of scope.
@@ -108,6 +107,7 @@ services: | |||
restart: always | |||
image: mongo:5.0 | |||
container_name: mongo | |||
command: "--replSet overleaf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this in scope?
Thanks for the contribution @fajfer! |
I kinda forget that I submitted this. I will try to respond today/tomorrow, there's another comment just below the one I submitted that looks more promising as it doesn't require another "init" container. I'm pretty sure it could be strange looking for usual docker users and looks more like a k8s-oriented approach (which imo doesn't fit into compose). Correct me if I'm wrong @bean5, since I'm so much used to working with Gerrit, but I think GitHub can squash commits while merging the PR? I usually didn't really care about cleanliness of my commit history on GitHub PRs but maybe I should start doing it if it's problematic. |
Description
Fix docker compose file based on #1120 (comment)
Contributor Agreement