Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mongoinit to fix initial docker-compose file #1218

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fajfer
Copy link

@fajfer fajfer commented Apr 30, 2024

Description

Fix docker compose file based on #1120 (comment)

Contributor Agreement

@bean5
Copy link

bean5 commented May 6, 2024

⚠️ Advised: squash

Reason: Merge exists on branch.

Copy link

@bean5 bean5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea this gets at. I don't know enough MongoDB (yet) to fully back this. That being said, I didn't see anything that looks obviously dangerous to merge--except if you do not squash it might not as clean of a merge.

@@ -1,4 +1,3 @@
version: '2.2'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope.

@@ -108,6 +107,7 @@ services:
restart: always
image: mongo:5.0
container_name: mongo
command: "--replSet overleaf"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this in scope?

@bean5
Copy link

bean5 commented May 6, 2024

Thanks for the contribution @fajfer!

@fajfer
Copy link
Author

fajfer commented May 6, 2024

I like the idea this gets at. I don't know enough MongoDB (yet) to fully back this. That being said, I didn't see anything that looks obviously dangerous to merge--except if you do not squash it might not as clean of a merge.

I kinda forget that I submitted this. I will try to respond today/tomorrow, there's another comment just below the one I submitted that looks more promising as it doesn't require another "init" container. I'm pretty sure it could be strange looking for usual docker users and looks more like a k8s-oriented approach (which imo doesn't fit into compose).

Correct me if I'm wrong @bean5, since I'm so much used to working with Gerrit, but I think GitHub can squash commits while merging the PR? I usually didn't really care about cleanliness of my commit history on GitHub PRs but maybe I should start doing it if it's problematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants