feat: allow user to set TOC display preference #6786
Conversation
| @@ -276,6 +282,31 @@ function Details() { | |||
| /> | |||
| </SettingRow> | |||
|
|
|||
| <SettingRow | |||
There was a problem hiding this comment.
Lets move this under the "Display" header, it's currently under "Behavior"
| @@ -276,6 +282,31 @@ function Details() { | |||
| /> | |||
| </SettingRow> | |||
|
|
|||
| <SettingRow | |||
| border={false} | |||
| label={t("Table of Contents Position")} | |||
There was a problem hiding this comment.
| label={t("Table of Contents Position")} | |
| label={t("Table of Contents position")} |
| )} | ||
| > | ||
| <InputSelect | ||
| ariaLabel={t("TOC position")} |
There was a problem hiding this comment.
| ariaLabel={t("TOC position")} | |
| ariaLabel={t("Table of Contents position")} |
| ariaLabel={t("TOC position")} | ||
| options={[ | ||
| { | ||
| label: "Left", |
There was a problem hiding this comment.
| label: "Left", | |
| label: t("Left"), |
| value: TOCPosition.Left, | ||
| }, | ||
| { | ||
| label: "Right", |
There was a problem hiding this comment.
| label: "Right", | |
| label: t("Right"), |
| }, | ||
| ]} | ||
| value={tocPosition} | ||
| onChange={(p: TOCPosition) => setTocPosition(p)} |
There was a problem hiding this comment.
| onChange={(p: TOCPosition) => setTocPosition(p)} | |
| onChange={setTocPosition} |
Should work, no? Or is typescript forcing the intermediate function
| @@ -540,6 +542,7 @@ class DocumentScene extends React.Component<Props> { | |||
| <Contents | |||
| headings={this.headings} | |||
| isFullWidth={document.fullWidth} | |||
| onLeftSide={tocOnLeftSide} | |||
There was a problem hiding this comment.
| onLeftSide={tocOnLeftSide} | |
| position={position} |
Lets continue to pass position down
Ohh.. Sorry, I missed testing the layout shifts with the sidebar open. |
|
Give it a go, honestly how the sidebar lives in the dom might just need rethinking – it's not especially great on the left side either :( There's a lot of complexity as it tries to keep the document content centered until there's no longer room and then moves to keeping the toc+document centered. |
When the sidebar is open, I don't find the TOC being obscured; however I do find layout shifts, no matter the display preference. |
Closes #6383