Refactor of event insertion #5909
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommoor
force-pushed
the
chore/event-refactor
branch
from
d4e9f87
to
05280ee
Compare
tommoor
force-pushed
the
chore/event-refactor
branch
from
b826ae1
to
65be484
Compare
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days |
tommoor
force-pushed
the
chore/event-refactor
branch
from
068bba7
to
a41a217
Compare
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
Automatically closed due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spiking on automatic insertion of events, using
ApiKeymodel as it's the simplest.Edit: Also
AttachmentandFileOperation.Needs more type-safety before continuing down this path, but overall this will be a ton more reliable than the current manual hookup approach and remove some largely useless commands that only exist to wrap event creation in a transaction