Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON to client #5553

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

JSON to client #5553

wants to merge 18 commits into from

Conversation

tommoor
Copy link
Member

@tommoor tommoor commented Jul 11, 2023

See issue for what this unlocks in terms of future functionality. Makes JSON rather than markdown the canonical source of truth for reading documents.

  • Test public shares
  • Test restoring revisions
  • Test applying templates
  • Bump editor version to force reload
  • Images in public docs
  • Backwards compat API requests
  • Bug: Cycle detected in computation asNavigationNode

closes #3000

@IamTaoChen
Copy link
Contributor

How about this work?

@tommoor tommoor marked this pull request as ready for review November 18, 2023 02:24
@@ -1014,15 +1016,7 @@ router.post(
document.collection = collection;

ctx.body = {
data:
apiVersion === 2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically a breaking API change but it should only have been used internally in previous versions

@@ -1278,15 +1272,7 @@ router.post(
});

ctx.body = {
data:
apiVersion === 2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically a breaking API change but it should only have been used internally in previous versions

@tommoor
Copy link
Member Author

tommoor commented Nov 18, 2023

Planning on migration to storing JSON content before continuing here as the performance implications of loading state from DB are questionable, but certainly not an improvement.

Copy link
Contributor

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale label Feb 17, 2024
Copy link
Contributor

Automatically closed due to inactivity

@github-actions github-actions bot closed this Feb 22, 2024
@tommoor tommoor reopened this Feb 22, 2024
@tommoor tommoor removed the stale label Feb 22, 2024
@IamTaoChen
Copy link
Contributor

Hi ,

I noticed that this pull request has not been updated for a while. Could you please let me know the current status?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to sending JSON rather than Markdown to client
2 participants