-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support for Grist embeds. (#3914)
* Add support for Grist embeds. * Change Grist integration to only support SaaS * Update Regex * Update shared/editor/embeds/index.tsx Co-authored-by: Apoorv Mishra <apoorvmishra101092@gmail.com> * Change Grist embed to use function based API * Convert standard URL into embed url * Update shared/editor/embeds/Grist.tsx Co-authored-by: Apoorv Mishra <apoorvmishra101092@gmail.com> * Update shared/editor/embeds/Grist.tsx Co-authored-by: Apoorv Mishra <apoorvmishra101092@gmail.com> * Update shared/editor/embeds/Grist.tsx Co-authored-by: Apoorv Mishra <apoorvmishra101092@gmail.com> * Lint and test updates Co-authored-by: Apoorv Mishra <apoorvmishra101092@gmail.com> Co-authored-by: Tom Moor <tom.moor@gmail.com>
- Loading branch information
1 parent
7a758f8
commit 7ead17a
Showing
4 changed files
with
68 additions
and
0 deletions.
There are no files selected for viewing
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
import Grist from "./Grist"; | ||
|
||
describe("Grist", () => { | ||
const match = Grist.ENABLED[0]; | ||
|
||
test("to be enabled on share link", () => { | ||
expect( | ||
"https://templates.getgrist.com/doc/afterschool-program/p/2?embed=true".match( | ||
match | ||
) | ||
).toBeTruthy(); | ||
expect( | ||
"https://docs.getgrist.com/sg5V93LuAije/Untitled-document/p/22?embed=true".match( | ||
match | ||
) | ||
).toBeTruthy(); | ||
expect( | ||
"https://templates.getgrist.com/doc/afterschool-program".match(match) | ||
).toBeTruthy(); | ||
}); | ||
|
||
test("to not be enabled elsewhere", () => { | ||
// Self hosted not yet supported | ||
expect( | ||
"http://grist.my.host.com/o/docs/doc/new~5cCkr6CtMArdA62ohSy5xB/p/1?embed=true".match( | ||
match | ||
) | ||
).toBe(null); | ||
expect( | ||
"https://my.get.grist.com/doc/afterschool-program?embed=true".match(match) | ||
).toBe(null); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import * as React from "react"; | ||
import Frame from "../components/Frame"; | ||
import Image from "../components/Image"; | ||
import { EmbedProps as Props } from "."; | ||
|
||
function Grist(props: Props) { | ||
return ( | ||
<Frame | ||
{...props} | ||
src={props.attrs.href.replace(/(\?embed=true)?$/, "?embed=true")} | ||
icon={ | ||
<Image | ||
src="/images/grist.png" | ||
alt="Grist Icon" | ||
width={16} | ||
height={16} | ||
/> | ||
} | ||
title="Grist Spreadsheet" | ||
border | ||
/> | ||
); | ||
} | ||
|
||
Grist.ENABLED = [new RegExp("^https?://([a-z.-]+\\.)?getgrist\\.com/(.+)$")]; | ||
|
||
export default Grist; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters