Update viz-scans-accum.rst #568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typo in function "update"
twslankard
requested review from
twslankard,
Samahu,
celentes,
chrisbayruns and
mtswisher
Samahu
requested changes
Nov 17, 2023
There was a problem hiding this comment.
Couldn't you have all the changes in the first request? I don't see a point of having two PRs since you are targeting the same branch, I advise you to close this PR and amend the first patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typo in function "update"
Related Issues & PRs
Summary of Changes
Type in function update
Validation