Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Project Entropic maps BARRIERE PELTIER #360

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

HugoPELTIER
Copy link

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@marcocuturi
Copy link
Contributor

Thanks!

can you fix the linter issues?

you can check first the CONTRIBUTING.md file and install pre-commit, and run it on your files.

Thanks!

@HugoPELTIER
Copy link
Author

Dear Mister Cuturi,

We apologise for the inconvenience. We have sorted out the problems with the commit and we applied pre-commit. Thank you in advance. Sincerely yours,

@HugoPELTIER
Copy link
Author

I am very sorry, it seems that the remaining errors are due to spell checks. In particular, the names of individuals seem to be considered as spell errors.

@@ -0,0 +1,1562 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos:

"based on the results of presented in"

"We considere"

"given the two probability distributions P and Q," -> given two, P, Q should be written in markdown

REF

idea: is the idea really to let \varepsilon go to 0?


Reply via ReviewNB

@@ -0,0 +1,1562 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #15.    entropic_pot = potentials.EntropicPotentials(

this is easier by just instantiating ot_sink.to_dual_potentials


Reply via ReviewNB

@michalk8 michalk8 added the project-2023 OT ENSAE 2023 label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project-2023 OT ENSAE 2023
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants