Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added request resource balance #4646

Merged
merged 6 commits into from
May 17, 2024
Merged

Conversation

reyaleman
Copy link
Contributor

Pull Request Prelude

Changes Proposed

Added request resource balance so it's triggered when the client requests certain resources (gold, charm points, prey wildcards, etc)

This is used in:

  • Cyclopedia window
  • Tournament window
  • Daily Reward window
  • Preys & Hunting Tasks window
  • Forge window
  • Probably wheel

Not used in:

  • Market
  • Npc shops

Issues addressed:
None.

EPuncker
EPuncker previously approved these changes Apr 8, 2024
@krecikondexin
Copy link

krecikondexin commented Apr 9, 2024

I'm not sure if charms point will work, did you test it?

please check this PR: #4614

@reyaleman
Copy link
Contributor Author

I'm not sure if charms point will work, did you test it?

please check this PR: #4614

When opening cyclopedia window it requests the following resources balances.

[Info] Requested resource type 0x1E (charm points)
[Info] Requested resource type 0x00 (gold in bank)
[Info] Requested resource type 0x01 (gold equipped)

Keep in mind it doesn't replaces that you'll have to send an updated balance when using any resource, i.e. when unlocking a charm and losing some charm points as the request only occurs when opening those type of windows.

@ranisalt
Copy link
Member

ranisalt commented Apr 10, 2024

Keep in mind it doesn't replaces that you'll have to send an updated balance when using any resource

Fun fact: the Tibia client handles this so badly that if your premium time expires while you are online, and you open your character list again (Ctrl+G by default), it will update premium status and shit itself closing everything that's premium-only, no matter what you are doing. It happened to me in the middle of a hunt :<

@ranisalt ranisalt merged commit 848d64f into otland:master May 17, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants