Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: build .deb & fixes #4514

Closed
wants to merge 1 commit into from
Closed

Conversation

DSpeichert
Copy link
Member

Pull Request Prelude

Changes Proposed

Issues addressed:

  • Ubuntu builds were not properly uploading binary to artifacts
  • a .deb package is now uploaded too
  • test workflow does not run unnecessarily

@ranisalt
Copy link
Member

ranisalt commented Aug 7, 2023

I doubt enough people use raw TFS without changes to warrant maintaining this.

@DSpeichert
Copy link
Member Author

I doubt enough people use raw TFS without changes to warrant maintaining this.

It's mostly easy of use for those who are sticking to a tagged branch, especially if I figure out a way to maintain an APT repo. Doesn't cost us anything to keep it here.

@ranisalt
Copy link
Member

ranisalt commented Aug 9, 2023

People can always use Docker for that, which is way easier, and works in every distro.

Doesn't cost us anything to keep it here.

I can see it does just by looking at the package list and seeing different packages from that Ubuntu and vcpkg install. It's a third list of dependencies (not counting the ones on the wiki) that we need to keep updated and that we will not keep updated

@DSpeichert DSpeichert closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants