Validate config keys #1886
Open
Validate config keys #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To properly test this, #1898 is needed. |
r4f4
force-pushed
the
validate-config-keys
branch
from
9e26124
to
215bf2f
Compare
|
Dropping WIP since with #1898 the tests pass. |
Signed-off-by: Rafael Fonseca <r4f4rfs@gmail.com>
When using `ostree config set`, invalid values given are written into new config file, without error given. Errors are just picked up the next time `ostree_reload_repo_config` is called. Instead, let's do some validation before setting the config value. Fixes ostreedev#1827 Signed-off-by: Rafael Fonseca <r4f4rfs@gmail.com>
Signed-off-by: Rafael Fonseca <r4f4rfs@gmail.com>
r4f4
force-pushed
the
validate-config-keys
branch
from
215bf2f
to
28425d5
Compare
|
Updated to make use of #1899 in the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP on the second patch because I want to confirm whether this is the desired approach.