feat(scanner): Adds branch name to FossID scan code. #8641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-bielecki-bosch
force-pushed
the
add_branch_name_to_fossid_scan_code
branch
from
efc3d6c
to
088c960
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8641 +/- ##
============================================
- Coverage 67.92% 67.88% -0.04%
- Complexity 1005 1165 +160
============================================
Files 244 244
Lines 7772 7732 -40
Branches 876 865 -11
============================================
- Hits 5279 5249 -30
- Misses 2110 2124 +14
+ Partials 383 359 -24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kamil-bielecki-bosch
force-pushed
the
add_branch_name_to_fossid_scan_code
branch
3 times, most recently
from
651c2b3
to
bbf6e42
Compare
Commit messages should be written in "imperative mood" and titles should not end in a dot, so use "feat(scanner): Add a branch name to the FossID scan code" |
nnobelis
reviewed
May 17, 2024
plugins/scanners/fossid/src/main/kotlin/FossIdNamingProvider.kt
Outdated
Show resolved
Hide resolved
|
Please also document the new builtin: https://github.com/oss-review-toolkit/ort/blob/main/plugins/scanners/fossid/src/main/kotlin/FossIdNamingProvider.kt#L28-L39 |
fviernau
requested changes
May 17, 2024
kamil-bielecki-bosch
force-pushed
the
add_branch_name_to_fossid_scan_code
branch
4 times, most recently
from
82595dc
to
4f493bc
Compare
kamil-bielecki-bosch
force-pushed
the
add_branch_name_to_fossid_scan_code
branch
3 times, most recently
from
35c3ced
to
c2f0f80
Compare
sschuberth
requested changes
May 24, 2024
plugins/scanners/fossid/src/main/kotlin/FossIdNamingProvider.kt
Outdated
Show resolved
Hide resolved
plugins/scanners/fossid/src/main/kotlin/FossIdNamingProvider.kt
Outdated
Show resolved
Hide resolved
plugins/scanners/fossid/src/main/kotlin/FossIdNamingProvider.kt
Outdated
Show resolved
Hide resolved
plugins/scanners/fossid/src/test/kotlin/FossIdNamingProviderTest.kt
Outdated
Show resolved
Hide resolved
plugins/scanners/fossid/src/test/kotlin/FossIdNamingProviderTest.kt
Outdated
Show resolved
Hide resolved
Add branch name (revision) to FossID scan code for easier identification of scanned source code. As FossID accepts maximum of 255 characters in scan code, branch name is trimmed to size, that is compliant with this constraint. Signed-off-by: Kamil Bielecki <kamil.bielecki@pl.bosch.com>
kamil-bielecki-bosch
force-pushed
the
add_branch_name_to_fossid_scan_code
branch
from
c2f0f80
to
f1628a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds branch name (revision) to FossID scan code for easier identification of scanned source code.
As FossID accepts maximum of 255 characters in scan code, branch name is trimmed to size, that is compliant with this constraint.