static-html: Re-design the project table(s) #8640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8640 +/- ##
=========================================
Coverage 67.92% 67.92%
Complexity 1005 1005
=========================================
Files 244 244
Lines 7772 7772
Branches 876 876
=========================================
Hits 5279 5279
Misses 2110 2110
Partials 383 383
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fviernau
force-pushed
the
static-html-project-table-redesign
branch
4 times, most recently
from
76a9d8c
to
3536b79
Compare
sschuberth
requested changes
May 15, 2024
| @@ -445,14 +445,17 @@ class StaticHtmlReporter : Reporter { | |||
| } | |||
|
|
|||
| tbody { | |||
| table.rows.forEachIndexed { rowIndex, row -> | |||
| projectRow(table.id.toCoordinates(), rowIndex + 1, row) | |||
| for (i in 0..<table.rows.size) { | |||
There was a problem hiding this comment.
Could be simplified to repeat(table.rows.size) { index ->.
| @@ -389,83 +389,79 @@ class StaticHtmlReporter : Reporter { | |||
| private fun DIV.projectTable(table: ProjectTable) { | |||
| val excludedClass = "excluded".takeIf { table.isExcluded() }.orEmpty() | |||
|
|
|||
| h2 { | |||
| div("project $excludedClass") { | |||
There was a problem hiding this comment.
Commit message:
- "One dedicated column for each, open and resolved / excluded issues." -> "One dedicated column for each open, resolved, and excluded issues."
- Typo in "vizually" -> "visually".
There was a problem hiding this comment.
Now there's a typo in "resolvedm,".
This removes the need to pass the project ID separately, and also simplifies an upcoming change. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Improve the readability in the caller. While at it, simplify the caller a bit. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Improve the readability in the caller. While at it, simplify the caller a bit. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
fviernau
force-pushed
the
static-html-project-table-redesign
branch
from
3536b79
to
127ba64
Compare
Previously, the project table view had the following aspects which are changed in this commit: 1. One dedicated column for each, analyzer and scanner issues. 2. The color and background color of each row is derived from the worst severity issue contained in that row. For example, if a row contains a hint and an error, the entire row shows in red, which is the color associated with an error. 3. If the entire project is excluded, the view looks the same, except for the opacity which is reduced a bit. This is changed as follows: 1. One dedicated column for each open, resolved, and excluded issues. 2. The issue view is limited to just the issue columns, whereas each issue is shown in a color indicating its severity or state. The colors are gray (excluded), green (resolved), red (error), yellow (warning) and blue (hint). So, the state of an issue no more affects the color of the entire row. 3. If the entire project is excluded, the opacity is still used to indicate that. However, the opacity of the issue columns is not affected anymore, because this looks nicer and the issues now properly indicate their exclusion anyway. 4. In order to visually establish a border between the issues, the view of the issue is changed to a card-view. Note: It is now possile to quickly grasp the open issues for each project in order of the severity, due to the use of the dedicated column for open issues. Furthermore, it is easy to add the ability of showing also the advisor issues (in an upcoming change) without the need to add another (advisor issues) column. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
fviernau
force-pushed
the
static-html-project-table-redesign
branch
from
127ba64
to
ca0a010
Compare
sschuberth
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue summary tables have been improved recently by [1], to show exactly one issue per row and to adhere to the excluded state. This change now improves the issues view in the project tables in several ways which also improves consistency in terms of the issue views with the summary tables.
Please see the individual commits for the details and the screenshots below.
[1] #8593
Part of: #7921.
Before
After