Implement generic config resolution #6785
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add classes to represent the different ORT tools, how they depend on each other, and which configuration the consume. This will be used to improve the consistency when replacing a previously resolved configuration. Also, it provides a good overview over the ORT tools. Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.io>
Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.io>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #6785 +/- ##
============================================
- Coverage 64.62% 64.53% -0.10%
Complexity 1955 1955
============================================
Files 322 322
Lines 16166 16190 +24
Branches 2296 2307 +11
============================================
Hits 10448 10448
- Misses 4726 4750 +24
Partials 992 992
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a model for the different ORT tools, how they depend on each other, and which configuration they consume. Use it to implement a generic function to resolve configuration and warn if re-resolving a previously resolved configuration can lead to inconsistencies in the result.
This is an early draft and by no means complete, no need to review yet.