Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helper-cli: Add helper merge command #5519

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

porsche-rbieniek
Copy link

This pull request adds a helper CLI command for merging multiple analyzer results into one.

We have a use case where a larger monorepo is maintained by multiple project teams, each responsible for a specific subdirectory of the monorepo.

Each product team delivers a seperate analyzer result for its subdirectory and the analysts in charge need a way to merge the individual analyzer results into one analyzer result.

In German law, the author and the copyright holder can be two seperate
legal entities and therefore also need to be treated separately.

Introduce a new copyright holder field that is now the primary source
for copyright holder information. Authors are still only used as
copyright holders if the `addAuthorsToCopyrights` option is enabled.

For now, all package manager implementations set empty copyright
holders. Filling the copyright holder field is left as an exercise for
future actions. Right now, the only way to add copyright holders is via
curations.

This change resolves oss-review-toolkit#4519.

Signed-off-by: Rainer Bieniek <extern.rainer.bieniek@porsche.de>
This helper CLI function is used by Porsche to solve the issue oss-review-toolkit#4364

The rationale behind this is that some projects at Porsche deliver individual
analyzer-results for each subproject in a large monorepo. The FOSS analyst needs
to see a condensed form of the individual dependency graphs across the project
monorepo. We solve this issue by merging all individual analyzer results into one.

Signed-off-by: Rainer Bieniek <extern.rainer.bieniek@porsche.de>
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #5519 (9472c74) into main (285f018) will decrease coverage by 4.78%.
The diff coverage is 78.12%.

@@             Coverage Diff              @@
##               main    #5519      +/-   ##
============================================
- Coverage     72.70%   67.91%   -4.79%     
- Complexity     2045     2076      +31     
============================================
  Files           267      268       +1     
  Lines         14124    15258    +1134     
  Branches       2109     2470     +361     
============================================
+ Hits          10269    10363      +94     
- Misses         2773     3807    +1034     
- Partials       1082     1088       +6     
Flag Coverage Δ
test 32.67% <36.20%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/main/kotlin/experimental/ExperimentalScanner.kt 45.12% <0.00%> (-8.35%) ⬇️
analyzer/src/main/kotlin/managers/Pip.kt 55.04% <50.00%> (-16.39%) ⬇️
analyzer/src/main/kotlin/managers/Stack.kt 69.00% <50.00%> (-18.90%) ⬇️
model/src/main/kotlin/licenses/LicenseInfo.kt 67.64% <50.00%> (-32.36%) ⬇️
...main/kotlin/licenses/DefaultLicenseInfoProvider.kt 66.66% <66.66%> (-10.53%) ⬇️
...el/src/main/kotlin/licenses/LicenseInfoResolver.kt 72.42% <73.68%> (-19.13%) ⬇️
analyzer/src/main/kotlin/managers/Carthage.kt 73.91% <75.00%> (-0.04%) ⬇️
analyzer/src/main/kotlin/managers/Bower.kt 67.10% <100.00%> (-20.73%) ⬇️
analyzer/src/main/kotlin/managers/Bundler.kt 59.76% <100.00%> (-12.46%) ⬇️
analyzer/src/main/kotlin/managers/Cargo.kt 72.61% <100.00%> (-14.53%) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 285f018...9472c74. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant