-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helper-cli: Add helper merge command #5519
Open
porsche-rbieniek
wants to merge
2
commits into
oss-review-toolkit:main
Choose a base branch
from
porsche-rbieniek:feature/add-helper-merge-command
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
helper-cli: Add helper merge command #5519
porsche-rbieniek
wants to merge
2
commits into
oss-review-toolkit:main
from
porsche-rbieniek:feature/add-helper-merge-command
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In German law, the author and the copyright holder can be two seperate legal entities and therefore also need to be treated separately. Introduce a new copyright holder field that is now the primary source for copyright holder information. Authors are still only used as copyright holders if the `addAuthorsToCopyrights` option is enabled. For now, all package manager implementations set empty copyright holders. Filling the copyright holder field is left as an exercise for future actions. Right now, the only way to add copyright holders is via curations. This change resolves oss-review-toolkit#4519. Signed-off-by: Rainer Bieniek <extern.rainer.bieniek@porsche.de>
This helper CLI function is used by Porsche to solve the issue oss-review-toolkit#4364 The rationale behind this is that some projects at Porsche deliver individual analyzer-results for each subproject in a large monorepo. The FOSS analyst needs to see a condensed form of the individual dependency graphs across the project monorepo. We solve this issue by merging all individual analyzer results into one. Signed-off-by: Rainer Bieniek <extern.rainer.bieniek@porsche.de>
Codecov Report
@@ Coverage Diff @@
## main #5519 +/- ##
============================================
- Coverage 72.70% 67.91% -4.79%
- Complexity 2045 2076 +31
============================================
Files 267 268 +1
Lines 14124 15258 +1134
Branches 2109 2470 +361
============================================
+ Hits 10269 10363 +94
- Misses 2773 3807 +1034
- Partials 1082 1088 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a helper CLI command for merging multiple analyzer results into one.
We have a use case where a larger monorepo is maintained by multiple project teams, each responsible for a specific subdirectory of the monorepo.
Each product team delivers a seperate analyzer result for its subdirectory and the analysts in charge need a way to merge the individual analyzer results into one analyzer result.